Received: from eggs.gnu.org ([209.51.188.92]:53521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGxpm-0004IJ-1Q for qemu-devel@nongnu.org; Wed, 17 Apr 2019 23:35:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGxpl-0000Ts-0I for qemu-devel@nongnu.org; Wed, 17 Apr 2019 23:35:34 -0400 Date: Thu, 18 Apr 2019 00:35:27 -0300 From: Eduardo Habkost Message-ID: <20190418033527.GD25134@habkost.net> References: <20190417025944.16154-1-ehabkost@redhat.com> <87sguhyykr.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sguhyykr.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH 0/5] Remove qdev_get_machine() call from ppc_cpu_parse_featurestr() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Peter Maydell , Thomas Huth , Like Xu , Riku Voipio , Mark Cave-Ayland , Laurent Vivier , qemu-ppc@nongnu.org, Igor Mammedov , Paolo Bonzini , David Gibson , Artyom Tarasenko , Richard Henderson On Wed, Apr 17, 2019 at 07:45:24AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > My initial goal was simple: removing the qdev_get_machine() call > > from ppc_cpu_parse_featurestr() because I want to make > > qdev_get_machine() available only to softmmu code. > > > > Before doing this, I had to make *-user not call > > CPUClass::parse_features() anymore (it was pointless to call it, > > anyway). > > > > While doing this, I decided to rename parse_cpu_model() to > > something clearer (parse_cpu_option()). > > > > As a nice side effect, now the dependency between machine object > > creation and parse_cpu_option() is not hidden anymore. > > Series > Reviewed-by: Markus Armbruster Thanks. I'm queueing this even though I agree with the comments at patch 2/5, because I'm already planning to send a separate cleanup series for cpu_class_by_name() and other related code. -- Eduardo