Received: from eggs.gnu.org ([209.51.188.92]:37464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGz1x-0004lq-N1 for qemu-devel@nongnu.org; Thu, 18 Apr 2019 00:52:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGz1w-0002jn-Nw for qemu-devel@nongnu.org; Thu, 18 Apr 2019 00:52:13 -0400 Date: Thu, 18 Apr 2019 01:52:08 -0300 From: Eduardo Habkost Message-ID: <20190418045208.GE25134@habkost.net> References: <20190417025944.16154-1-ehabkost@redhat.com> <20190417025944.16154-4-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190417025944.16154-4-ehabkost@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/5] linux-user: Use lookup_cpu_class() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Laurent Vivier , Paolo Bonzini , Riku Voipio , Like Xu , Richard Henderson , David Gibson , Thomas Huth , Igor Mammedov , qemu-ppc@nongnu.org, Markus Armbruster , Peter Maydell , Artyom Tarasenko , Mark Cave-Ayland On Tue, Apr 16, 2019 at 11:59:42PM -0300, Eduardo Habkost wrote: > The return value of cpu_get_model() is just a CPU model name and > never includes extra options. We don't need to call > parse_cpu_option(). Oops. I was wrong. linux-user also supports extra features in the "-cpu" option, so we do need to call parse_cpu_option(). e.g.: this worked before: $ qemu-x86_64 -cpu Nehalem,+popcnt /bin/true and now this is broken: $ qemu-x86_64 -cpu Nehalem,+popcnt /bin/true unable to find CPU model 'Nehalem,+popcnt' I will drop patches 2-5 from my queue. Sorry for the noise. -- Eduardo