Received: from eggs.gnu.org ([209.51.188.92]:56773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hH7uS-0000Q4-Rp for qemu-devel@nongnu.org; Thu, 18 Apr 2019 10:21:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hH7uR-000226-LE for qemu-devel@nongnu.org; Thu, 18 Apr 2019 10:21:04 -0400 Date: Thu, 18 Apr 2019 14:20:58 +0000 From: Wei Yang Message-ID: <20190418142058.qvicrirxfghfosiu@master> Reply-To: Wei Yang References: <20190417014038.26018-1-richardw.yang@linux.intel.com> <20190417014038.26018-7-richardw.yang@linux.intel.com> <20190418130241.635b2e97@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190418130241.635b2e97@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 6/6] acpi: pci: use build_append_foo() API to construct MCFG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Wei Yang , yang.zhong@intel.com, peter.maydell@linaro.org, mst@redhat.com, qemu-devel@nongnu.org, shannon.zhaosl@gmail.com, qemu-arm@nongnu.org, philmd@redhat.com On Thu, Apr 18, 2019 at 01:02:41PM +0200, Igor Mammedov wrote: >On Wed, 17 Apr 2019 09:40:38 +0800 >Wei Yang wrote: > >> build_append_foo() API doesn't need explicit endianness conversions >> which eliminates a source of errors and it makes build_mcfg() look like >> declarative definition of MCFG table in ACPI spec, which makes it easy >> to review. >> >> Signed-off-by: Wei Yang >> Suggested-by: Igor Mammedov >Thanks for nice cleanup! Glad you like it. :-) > >with comment fixed up: >Reviewed-by: Igor Mammedov > >> --- >> hw/acpi/pci.c | 30 ++++++++++++++++++------------ >> include/hw/acpi/acpi-defs.h | 18 ------------------ >> 2 files changed, 18 insertions(+), 30 deletions(-) >> >> diff --git a/hw/acpi/pci.c b/hw/acpi/pci.c >> index fa0fa30bb9..05050fa087 100644 >> --- a/hw/acpi/pci.c >> +++ b/hw/acpi/pci.c >> @@ -30,17 +30,23 @@ >> >> void build_mcfg(GArray *table_data, BIOSLinker *linker, AcpiMcfgInfo *info) >> { >> - AcpiTableMcfg *mcfg; >> - int len = sizeof(*mcfg) + sizeof(mcfg->allocation[0]); >> - >> - mcfg = acpi_data_push(table_data, len); >> - mcfg->allocation[0].address = cpu_to_le64(info->base); >> - >> - /* Only a single allocation so no need to play with segments */ >> - mcfg->allocation[0].pci_segment = cpu_to_le16(0); >> - mcfg->allocation[0].start_bus_number = 0; >> - mcfg->allocation[0].end_bus_number = PCIE_MMCFG_BUS(info->size - 1); >> - >> - build_header(linker, table_data, (void *)mcfg, "MCFG", len, 1, NULL, NULL); >> + int mcfg_start = table_data->len; >> + >> + acpi_data_push(table_data, sizeof(AcpiTableHeader)); >> + >> + /* PCI fw r3.0 MCFG table. */ >It would be better to put spec name as is here so simple search >could immediately point to it. > >like: PCI Firmware Specification, Revision 3.0 > 4.1.2 MCFG Table Description > Sure, will change to this. -- Wei Yang Help you, Help me