Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF7CEC282DF for ; Fri, 19 Apr 2019 20:07:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8B912171F for ; Fri, 19 Apr 2019 20:07:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727914AbfDSUHC (ORCPT ); Fri, 19 Apr 2019 16:07:02 -0400 Received: from ch3vs04.rockwellcollins.com ([205.175.226.52]:35657 "EHLO ch3vs04.rockwellcollins.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726804AbfDSUHC (ORCPT ); Fri, 19 Apr 2019 16:07:02 -0400 Received: from ofwch3n02.rockwellcollins.com (HELO ciulimr01.rockwellcollins.com) ([205.175.226.14]) by ch3vs04.rockwellcollins.com with ESMTP; 19 Apr 2019 11:44:42 -0500 X-Received: from CRM18509.rockwellcollins.com (crm18509.rockwellcollins.com [10.142.2.254]) by ciulimr01.rockwellcollins.com (Postfix) with ESMTP id E4F956029D; Fri, 19 Apr 2019 11:44:41 -0500 (CDT) From: robert.mccabe@collins.com To: netdev@vger.kernel.org Cc: robertjmccabe@gmail.com, "McCabe, Robert J" , rjmccabe3701 Subject: [PATCH bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error Date: Fri, 19 Apr 2019 11:44:41 -0500 Message-Id: <20190419164441.2962-1-robert.mccabe@collins.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "McCabe, Robert J" The BPF_PROG_LOAD condition for kernel version <= 5.1 is log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */ Signed-off-by: rjmccabe3701 --- tools/lib/bpf/bpf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h index bc30783d1403..62d67caa7aea 100644 --- a/tools/lib/bpf/bpf.h +++ b/tools/lib/bpf/bpf.h @@ -92,7 +92,7 @@ struct bpf_load_program_attr { #define MAPS_RELAX_COMPAT 0x01 /* Recommend log buffer size */ -#define BPF_LOG_BUF_SIZE (16 * 1024 * 1024) /* verifier maximum in kernels <= 5.1 */ +#define BPF_LOG_BUF_SIZE ((16 * 1024 * 1024) - 1) /* verifier maximum in kernels <= 5.1 */ LIBBPF_API int bpf_load_program_xattr(const struct bpf_load_program_attr *load_attr, char *log_buf, size_t log_buf_sz); -- 2.17.1