From: Andrew Lunn Subject: Re: [PATCH v2] net: stmmac: move stmmac_check_ether_addr() to driver probe Date: Mon, 22 Apr 2019 15:30:36 +0200 Message-ID: <20190422133036.GB12718@lunn.ch> References: <20190422094532.5519-1-vkoul@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190422094532.5519-1-vkoul@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Vinod Koul Cc: Florian Fainelli , Alexandre Torgue , linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Xiaofei Shen , Vivien Didelot , Bjorn Andersson , Jose Abreu , Sneh Shah , Maxime Coquelin , netdev@vger.kernel.org, Niklas Cassel , Giuseppe Cavallaro , "David S. Miller" , linux-arm-kernel@lists.infradead.org List-Id: linux-arm-msm@vger.kernel.org On Mon, Apr 22, 2019 at 03:15:32PM +0530, Vinod Koul wrote: > stmmac_check_ether_addr() checks the MAC address and assigns one in > driver open(). In many cases when we create slave netdevice, the dev > addr is inherited from master but the master dev addr maybe NULL at > that time, so move this call to driver probe so that address is > always valid. > > Signed-off-by: Xiaofei Shen > Tested-by: Xiaofei Shen > Signed-off-by: Sneh Shah > Signed-off-by: Vinod Koul Thanks for doing it this way. Reviewed-by: Andrew Lunn Andrew