Received: from eggs.gnu.org ([209.51.188.92]:56320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIamv-0005Lc-Ef for qemu-devel@nongnu.org; Mon, 22 Apr 2019 11:23:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIamu-0006GX-5H for qemu-devel@nongnu.org; Mon, 22 Apr 2019 11:23:21 -0400 From: Vladimir Sementsov-Ogievskiy Date: Mon, 22 Apr 2019 18:23:12 +0300 Message-Id: <20190422152315.74361-1-vsementsov@virtuozzo.com> Subject: [Qemu-devel] [PATCH v4 0/3] Fix overflow bug in qcow2 discard List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, fam@euphon.net, stefanha@redhat.com, vsementsov@virtuozzo.com, den@virtuozzo.com, eblake@redhat.com v4: now based on Kevin's block-next 01: add Eric's r-b 02: - s/which/where/ [Eric, hope, I fixed correct one which from two:)] - s/it's/its add Eric's r-b 03: - r-b and t-b by Eric - grammar - drop trace from test v3: don't filter mapping info from qemu-img map output, otherwise it don't show what I try to check [sorry for extra noise in list] v2: [mostly by Eric's review] 01: new 02: point to bug introducing commit in cover letter [Eric] [but I failed to compile it, to check] drop s/INT_MAX/BDRV_REQUEST_MAX_BYTES/ chunk 03: - improve wording - cheating with preallocation=metadata and discards to make test quick and not eating disk space - use new trace-point - move it to be 250 iotest - filter out extra qemu-img info output Based-on: git://repo.or.cz/qemu/kevin.git block-next Vladimir Sementsov-Ogievskiy (3): block/qcow2-refcount: add trace-point to qcow2_process_discards block/io: bdrv_pdiscard: support int64_t bytes parameter iotests: test big qcow2 shrink include/block/block.h | 4 +-- block/io.c | 16 ++++----- block/qcow2-refcount.c | 7 +++- block/trace-events | 3 ++ tests/qemu-iotests/250 | 72 ++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/250.out | 21 +++++++++++ tests/qemu-iotests/group | 1 + 7 files changed, 113 insertions(+), 11 deletions(-) create mode 100755 tests/qemu-iotests/250 create mode 100644 tests/qemu-iotests/250.out -- 2.18.0