From: Christoph Hellwig Subject: Re: [PATCH v3 02/10] swiotlb: Factor out slot allocation and free Date: Tue, 23 Apr 2019 08:12:32 +0200 Message-ID: <20190423061232.GB12762@lst.de> References: <20190421011719.14909-1-baolu.lu@linux.intel.com> <20190421011719.14909-3-baolu.lu@linux.intel.com> <20190422164555.GA31181@lst.de> <0c6e5983-312b-0d6b-92f5-64861cd6804d@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <0c6e5983-312b-0d6b-92f5-64861cd6804d@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Lu Baolu Cc: Christoph Hellwig , David Woodhouse , Joerg Roedel , ashok.raj@intel.com, jacob.jun.pan@intel.com, alan.cox@intel.com, kevin.tian@intel.com, mika.westerberg@linux.intel.com, pengfei.xu@intel.com, Konrad Rzeszutek Wilk , Marek Szyprowski , Robin Murphy , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org List-Id: iommu@lists.linux-foundation.org On Tue, Apr 23, 2019 at 09:58:19AM +0800, Lu Baolu wrote: > 554 for (i = 0; i < nslots; i++) > 555 io_tlb_orig_addr[index+i] = orig_addr + (i << > IO_TLB_SHIFT); > > Could the tlb orig address set to PAGE_ALIGN_DOWN(orig_addr)? We > couldn't assume the bounce buffer just starts from the beginning of the > slot. Or anything I missed? I don't see why we need to align the orig_addr. We only use io_tlb_orig_addr to find the address(es) for the swiotlb_bounce calls, and I don't see a good reason why we'd need to align those.