Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09886C10F03 for ; Tue, 23 Apr 2019 19:12:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBC20217D9 for ; Tue, 23 Apr 2019 19:12:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="417UbyA8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726351AbfDWTMz (ORCPT ); Tue, 23 Apr 2019 15:12:55 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:41838 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725957AbfDWTMz (ORCPT ); Tue, 23 Apr 2019 15:12:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Q/13wNrowO1aAwCtgdwkF/8A9WCnQ6q/9AtIn5ju7BQ=; b=417UbyA85NzWQAn8vPiTaBVkTy p8gEbZXBMzc/nNBTXNPZiN2WYw1xphDWac9cI85mwd8hiGGWUivgdKGge8BA8M7uYISXbcteDaw+n FDZSuKejWJoXlAWN31TDa+GK0oPTFup41c4rW6HymXm1Vs2Hz3QzLWKrbDc3DwFS29KU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hJ0qY-00021c-VK; Tue, 23 Apr 2019 21:12:50 +0200 Date: Tue, 23 Apr 2019 21:12:50 +0200 From: Andrew Lunn To: Igor Russkikh Cc: "David S . Miller" , "netdev@vger.kernel.org" , Nikita Danilov , Dmitry Bogdanov , Yana Esina Subject: Re: [PATCH v2 net-next 01/16] net: aquantia: add infrastructure to readout chip temperature Message-ID: <20190423191250.GK28405@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Apr 23, 2019 at 01:17:29PM +0000, Igor Russkikh wrote: > From: Yana Esina > > Ability to read the chip temperature from memory > via hwmon interface > > Signed-off-by: Yana Esina > Signed-off-by: Nikita Danilov > Signed-off-by: Igor Russkikh > --- > .../net/ethernet/aquantia/atlantic/aq_hw.h | 2 ++ > .../aquantia/atlantic/hw_atl/hw_atl_utils.c | 1 + > .../atlantic/hw_atl/hw_atl_utils_fw2x.c | 36 +++++++++++++++++++ > 3 files changed, 39 insertions(+) > > diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_hw.h b/drivers/net/ethernet/aquantia/atlantic/aq_hw.h > index 81aab73dc22f..538593261ae3 100644 > --- a/drivers/net/ethernet/aquantia/atlantic/aq_hw.h > +++ b/drivers/net/ethernet/aquantia/atlantic/aq_hw.h > @@ -259,6 +259,8 @@ struct aq_fw_ops { > > int (*update_stats)(struct aq_hw_s *self); > > + int (*get_temp)(struct aq_hw_s *self, int *temp); > + We talked about renaming this get_phy_temp so you could later add get_mac_temp? Andrew