From: Christoph Hellwig Subject: Re: [PATCH] iommu/amd: flush not present cache in iommu_map_page Date: Wed, 24 Apr 2019 07:58:19 -0700 Message-ID: <20190424145819.GA16141@infradead.org> References: <20190424141900.8883-1-tmurphy@arista.com> <20190424143246.GA24079@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tom Murphy , Joerg Roedel Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tom Murphy List-Id: iommu@lists.linux-foundation.org On Wed, Apr 24, 2019 at 03:47:39PM +0100, Tom Murphy wrote: > >And I'd really like to understand the unlikely - amd_iommu_np_cache > >is set based on a hardware capability, so it seems rather odd to mark > >it unlikely. Dynamic branch prediction really should do the right thing > >here usually. > > Here is the commit which added it without any explanation: > https://github.com/torvalds/linux/commit/270cab2426cdc6307725e4f1f46ecf8ab8e69193 > > should we remove it seen as there's no explanation given ? I'd be tempted to do that. But lets just ask Joerg if he has any opinion..