From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v3 08/10] iommu/vt-d: Check whether device requires bounce buffer Date: Wed, 24 Apr 2019 14:27:30 -0400 Message-ID: <20190424182730.GA17505@char.us.oracle.com> References: <20190421011719.14909-1-baolu.lu@linux.intel.com> <20190421011719.14909-9-baolu.lu@linux.intel.com> <20190422164755.GC31181@lst.de> <76e35340-32c3-ee0d-5232-bd8800248402@linux.intel.com> <20190423060858.GA12762@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Lu Baolu Cc: kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, alan.cox-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Robin Murphy , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pengfei.xu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, jacob.jun.pan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, David Woodhouse , Christoph Hellwig List-Id: iommu@lists.linux-foundation.org On Tue, Apr 23, 2019 at 03:35:51PM +0800, Lu Baolu wrote: > Hi, > > On 4/23/19 2:08 PM, Christoph Hellwig wrote: > > > > Again, this and the option should not be in a specific iommu driver. > > > > > > > > > > The option of whether bounce is ignored should be in the specific iommu > > > driver. > > > > Why? As a user I could not care less which IOMMU driver my particular > > system uses. > > > > Looks reasonable to me. Let's listen to more opinions. I agree with Christoph here. > > Best regards, > Lu Baolu