From: kbusch@kernel.org (Keith Busch) Date: Wed, 24 Apr 2019 14:07:06 -0600 Subject: [PATCH v2 0/2] Adding per-controller timeout support to nvme In-Reply-To: References: <20190403123506.122904-1-mheyne@amazon.de> Message-ID: <20190424200706.GB15412@localhost.localdomain> On Wed, Apr 24, 2019@09:55:16AM -0700, Sagi Grimberg wrote: > > > As different nvme controllers are connect via different fabrics, some require > > different timeout settings than others. This series implements per-controller > > timeouts in the nvme subsystem which can be set via sysfs. > > How much of a real issue is this? > > block io_timeout defaults to 30 seconds which are considered a universal > eternity for pretty much any nvme fabric. Moreover, io_timeout is > mutable already on a per-namespace level. > > This leaves the admin_timeout which goes beyond this to 60 seconds... > > Can you describe what exactly are you trying to solve? I think they must have an nvme target that is backed by slow media (i.e. non-SSD). If that's the case, I think it may be a better option if the target advertises relatively shallow queue depths and/or lower MDTS that better aligns to the backing storage capabilies.