Received: from eggs.gnu.org ([209.51.188.92]:40817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJYl6-00071d-Bh for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:25:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJYl5-00061E-B3 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:25:28 -0400 Received: from mga02.intel.com ([134.134.136.20]:58897) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJYl5-00060R-32 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:25:27 -0400 Date: Thu, 25 Apr 2019 15:24:55 +0800 From: Wei Yang Message-ID: <20190425072455.GB24344@richard> Reply-To: Wei Yang References: <1556170489-131927-1-git-send-email-imammedo@redhat.com> <1556170489-131927-3-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1556170489-131927-3-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 02/13] tests: acpi: rename acpi_parse_rsdp_table() into acpi_fetch_rsdp_table() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, Laszlo Ersek , "Michael S. Tsirkin" , Gonglei , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Shannon Zhao , Wei Yang , Andrew Jones , Shameer Kolothum , Ben Warren On Thu, Apr 25, 2019 at 07:34:38AM +0200, Igor Mammedov wrote: >so name would reflect what the function does > >Signed-off-by: Igor Mammedov >Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wei Yang >--- > tests/acpi-utils.h | 2 +- > tests/acpi-utils.c | 2 +- > tests/bios-tables-test.c | 2 +- > tests/vmgenid-test.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/tests/acpi-utils.h b/tests/acpi-utils.h >index 8c68201..75f78f2 100644 >--- a/tests/acpi-utils.h >+++ b/tests/acpi-utils.h >@@ -46,7 +46,7 @@ typedef struct { > > uint8_t acpi_calc_checksum(const uint8_t *data, int len); > uint32_t acpi_find_rsdp_address(QTestState *qts); >-void acpi_parse_rsdp_table(QTestState *qts, uint64_t addr, uint8_t *rsdp_table); >+void acpi_fetch_rsdp_table(QTestState *qts, uint64_t addr, uint8_t *rsdp_table); > void acpi_fetch_table(QTestState *qts, uint8_t **aml, uint32_t *aml_len, > const uint8_t *addr_ptr, const char *sig, > bool verify_checksum); >diff --git a/tests/acpi-utils.c b/tests/acpi-utils.c >index 9a6d1d3..2dd4fe0 100644 >--- a/tests/acpi-utils.c >+++ b/tests/acpi-utils.c >@@ -51,7 +51,7 @@ uint32_t acpi_find_rsdp_address(QTestState *qts) > return off; > } > >-void acpi_parse_rsdp_table(QTestState *qts, uint64_t addr, uint8_t *rsdp_table) >+void acpi_fetch_rsdp_table(QTestState *qts, uint64_t addr, uint8_t *rsdp_table) > { > uint8_t revision; > >diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c >index 24bd102..2ee044c 100644 >--- a/tests/bios-tables-test.c >+++ b/tests/bios-tables-test.c >@@ -89,7 +89,7 @@ static void test_acpi_rsdp_table(test_data *data) > uint8_t *rsdp_table = data->rsdp_table, revision; > uint32_t addr = data->rsdp_addr; > >- acpi_parse_rsdp_table(data->qts, addr, rsdp_table); >+ acpi_fetch_rsdp_table(data->qts, addr, rsdp_table); > revision = rsdp_table[15 /* Revision offset */]; > > switch (revision) { >diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c >index ae38ee5..f400184 100644 >--- a/tests/vmgenid-test.c >+++ b/tests/vmgenid-test.c >@@ -40,7 +40,7 @@ static uint32_t acpi_find_vgia(QTestState *qts) > g_assert_cmphex(rsdp_offset, <, RSDP_ADDR_INVALID); > > >- acpi_parse_rsdp_table(qts, rsdp_offset, rsdp_table); >+ acpi_fetch_rsdp_table(qts, rsdp_offset, rsdp_table); > acpi_fetch_table(qts, &rsdt, &rsdt_len, &rsdp_table[16 /* RsdtAddress */], > "RSDT", true); > >-- >2.7.4 -- Wei Yang Help you, Help me