Received: from eggs.gnu.org ([209.51.188.92]:43596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJZ1U-00024O-9l for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:42:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJYre-0002Lx-77 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:32:15 -0400 Received: from mga01.intel.com ([192.55.52.88]:20163) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJYrd-0002Lh-VX for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:32:14 -0400 Date: Thu, 25 Apr 2019 15:31:42 +0800 From: Wei Yang Message-ID: <20190425073142.GA24829@richard> Reply-To: Wei Yang References: <1556170489-131927-1-git-send-email-imammedo@redhat.com> <1556170489-131927-4-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1556170489-131927-4-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 03/13] tests: acpi: make pointer to RSDP 64bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, Laszlo Ersek , "Michael S. Tsirkin" , Gonglei , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Shannon Zhao , Wei Yang , Andrew Jones , Shameer Kolothum , Ben Warren On Thu, Apr 25, 2019 at 07:34:39AM +0200, Igor Mammedov wrote: >In case of UEFI, RSDP doesn't have to be located in lowmem, >it could be placed at any address. Make sure that test won't >break if it is placed above the first 4Gb of address space. > >PS: >While at it cleanup some local variables as we don't really >need them. > >Signed-off-by: Igor Mammedov >Reviewed-by: Philippe Mathieu-Daudé >--- >v2: > - s/In case of UEFI/In case of UEFI,/ (Laszlo Ersek ) >--- > tests/bios-tables-test.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > >diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c >index 2ee044c..c29dcf4 100644 >--- a/tests/bios-tables-test.c >+++ b/tests/bios-tables-test.c >@@ -26,7 +26,7 @@ > typedef struct { > const char *machine; > const char *variant; >- uint32_t rsdp_addr; >+ uint64_t rsdp_addr; > uint8_t rsdp_table[36 /* ACPI 2.0+ RSDP size */]; > GArray *tables; > uint32_t smbios_ep_addr; >@@ -86,13 +86,11 @@ static void test_acpi_rsdp_address(test_data *data) > > static void test_acpi_rsdp_table(test_data *data) > { >- uint8_t *rsdp_table = data->rsdp_table, revision; >- uint32_t addr = data->rsdp_addr; >+ uint8_t *rsdp_table = data->rsdp_table; > >- acpi_fetch_rsdp_table(data->qts, addr, rsdp_table); >- revision = rsdp_table[15 /* Revision offset */]; >+ acpi_fetch_rsdp_table(data->qts, data->rsdp_addr, rsdp_table); Ok, I think this is the reason you change the second parameter from uint32_t to uint64_t in 1st patch. Maybe we need to move that on to this one? > >- switch (revision) { >+ switch (rsdp_table[15 /* Revision offset */]) { > case 0: /* ACPI 1.0 RSDP */ > /* With rev 1, checksum is only for the first 20 bytes */ > g_assert(!acpi_calc_checksum(rsdp_table, 20)); >-- >2.7.4 -- Wei Yang Help you, Help me