Received: from eggs.gnu.org ([209.51.188.92]:33638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJeTb-0003Pe-A9 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 09:31:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJeTa-00068B-6H for qemu-devel@nongnu.org; Thu, 25 Apr 2019 09:31:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58074) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJeTZ-00067t-UP for qemu-devel@nongnu.org; Thu, 25 Apr 2019 09:31:46 -0400 Date: Thu, 25 Apr 2019 15:31:34 +0200 From: Igor Mammedov Message-ID: <20190425153134.585b614d@redhat.com> In-Reply-To: <1f64a17a-57e8-448f-ced2-860d137eebaa@redhat.com> References: <1556170489-131927-1-git-send-email-imammedo@redhat.com> <1556170489-131927-12-git-send-email-imammedo@redhat.com> <1f64a17a-57e8-448f-ced2-860d137eebaa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 11/13] tests: acpi: add simple arm/virt testcase List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-devel@nongnu.org, Andrew Jones , Ben Warren , "Michael S. Tsirkin" , Shameer Kolothum , Shannon Zhao , Gonglei , Wei Yang , Laszlo Ersek On Thu, 25 Apr 2019 14:41:28 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > On 4/25/19 7:34 AM, Igor Mammedov wrote: > > adds simple arm/virt test case that starts guest with > > bios-tables-test.aarch64.iso.qcow2 boot image which > > initializes UefiTestSupport* structure in RAM once > > guest is booted. > >=20 > > * see commit: tests: acpi: add acpi_find_rsdp_address_uefi() helper > >=20 > > Signed-off-by: Igor Mammedov > > Reviewed-by: Laszlo Ersek =20 >=20 > > Reviewed-by: Philippe Mathieu-Daud=C3=A9 =20 > Please replace previous R-b by: done > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Tested-by: Philippe Mathieu-Daud=C3=A9 >=20 > > --- > > v3: > > * use firmware blobs directly from pc-bios directory > > * use bios-tables-test.aarch64.iso.qcow2 as test boot image > > * drop leftover qtest-uefi-images-aarch64 iMakefile rule from > > previos version (Laszlo) > > * add Makefile rule to include bios-tables-test into > > check-qtest-aarch64 target > > v2: > > * specify in test_data where board's RAM starts and RAM size > > --- > > tests/Makefile.include | 1 + > > tests/bios-tables-test.c | 17 +++++++++++++++++ > > 2 files changed, 18 insertions(+) > >=20 > > diff --git a/tests/Makefile.include b/tests/Makefile.include > > index e2432d5..983c8b1 100644 > > --- a/tests/Makefile.include > > +++ b/tests/Makefile.include > > @@ -267,6 +267,7 @@ check-qtest-arm-y +=3D tests/hexloader-test$(EXESUF) > > check-qtest-aarch64-y =3D tests/numa-test$(EXESUF) > > check-qtest-aarch64-y +=3D tests/boot-serial-test$(EXESUF) > > check-qtest-aarch64-y +=3D tests/migration-test$(EXESUF) > > +check-qtest-aarch64-y +=3D tests/bios-tables-test$(EXESUF) > > =20 > > check-qtest-microblazeel-y +=3D $(check-qtest-microblaze-y) > > =20 > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > > index 1be55a1..f117461 100644 > > --- a/tests/bios-tables-test.c > > +++ b/tests/bios-tables-test.c > > @@ -812,6 +812,21 @@ static void test_acpi_piix4_tcg_dimm_pxm(void) > > test_acpi_tcg_dimm_pxm(MACHINE_PC); > > } > > =20 > > +static void test_acpi_virt_tcg(void) > > +{ > > + test_data data =3D { > > + .machine =3D "virt", > > + .uefi_fl1 =3D "pc-bios/edk2-aarch64-code.fd", > > + .uefi_fl2 =3D "pc-bios/edk2-arm-vars.fd", > > + .cd =3D "tests/data/uefi-boot-images/bios-tables-test.aarch64.= iso.qcow2", > > + .ram_start =3D 0x40000000ULL, > > + .scan_len =3D 128ULL * 1024 * 1024, > > + }; > > + > > + test_acpi_one("-cpu cortex-a57 ", &data); > > + free_test_data(&data); > > +} > > + > > int main(int argc, char *argv[]) > > { > > const char *arch =3D qtest_get_arch(); > > @@ -840,6 +855,8 @@ int main(int argc, char *argv[]) > > qtest_add_func("acpi/q35/numamem", test_acpi_q35_tcg_numamem); > > qtest_add_func("acpi/piix4/dimmpxm", test_acpi_piix4_tcg_dimm_= pxm); > > qtest_add_func("acpi/q35/dimmpxm", test_acpi_q35_tcg_dimm_pxm); > > + } else if (strcmp(arch, "aarch64") =3D=3D 0) { > > + qtest_add_func("acpi/virt", test_acpi_virt_tcg); > > } > > ret =3D g_test_run(); > > boot_sector_cleanup(disk); > > =20 >=20