Received: from eggs.gnu.org ([209.51.188.92]:57114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLbh5-00019q-Oh for qemu-devel@nongnu.org; Tue, 30 Apr 2019 18:57:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLbXz-0002C9-GO for qemu-devel@nongnu.org; Tue, 30 Apr 2019 18:48:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44130) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLbXz-0002AL-B3 for qemu-devel@nongnu.org; Tue, 30 Apr 2019 18:48:23 -0400 Date: Tue, 30 Apr 2019 19:48:16 -0300 From: Eduardo Habkost Message-ID: <20190430224816.GL28722@habkost.net> References: <20190426003652.32633-1-richardw.yang@linux.intel.com> <20190426003652.32633-2-richardw.yang@linux.intel.com> <20190430204636.GK28722@habkost.net> <20190430223618.lyl3ribm7gg5haa5@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190430223618.lyl3ribm7gg5haa5@master> Subject: Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Yang Cc: Wei Yang , pagupta@redhat.com, xiaoguangrong.eric@gmail.com, mst@redhat.com, Haozhong Zhang , qemu-devel@nongnu.org, yi.z.zhang@linux.intel.com, yu.c.zhang@linux.intel.com, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com On Tue, Apr 30, 2019 at 10:36:18PM +0000, Wei Yang wrote: [...] > >> +#ifdef CONFIG_LINUX > >> +#include > >> +#endif /* CONFIG_LINUX */ > >> + > >> +#ifndef MAP_SYNC > >> +#define MAP_SYNC 0 > >> +#endif > >> +#ifndef MAP_SHARED_VALIDATE > >> +#define MAP_SHARED_VALIDATE 0 > >> +#endif > > > >Why would we need this, if we added copies of mman.h to > >linux-headers? > > This is reported by Stefan. > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg612168.html Stefan, did you hit a build failure, or it was just theoretical? linux-headers/*/mman.h is updated by "linux-headers: add linux/mman.h" (commit 8cf108c5d159). If the build really fails, something else is broken in our build system. -- Eduardo