Received: from eggs.gnu.org ([209.51.188.92]:51525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLlpq-0001al-Q5 for qemu-devel@nongnu.org; Wed, 01 May 2019 05:47:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLlpn-0002OO-OU for qemu-devel@nongnu.org; Wed, 01 May 2019 05:47:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49300) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLlpn-0002No-HS for qemu-devel@nongnu.org; Wed, 01 May 2019 05:47:27 -0400 Date: Wed, 1 May 2019 10:47:23 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20190501094722.GB10995@work-vm> References: <20190412152652.827-1-dgilbert@redhat.com> <20190415094552.GC29134@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190415094552.GC29134@stefanha-x1.localdomain> Subject: Re: [Qemu-devel] [PATCH] hmp: gva2gpa debug command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, armbru@redhat.com * Stefan Hajnoczi (stefanha@gmail.com) wrote: > On Fri, Apr 12, 2019 at 04:26:52PM +0100, Dr. David Alan Gilbert (git) wrote: > > diff --git a/hmp-commands.hx b/hmp-commands.hx > > index d3bad2fc27..ba4690b9ac 100644 > > --- a/hmp-commands.hx > > +++ b/hmp-commands.hx > > @@ -585,6 +585,21 @@ STEXI > > @findex gpa2hpa > > Print the host physical address at which the guest's physical address @var{addr} > > is mapped. > > +ETEXI > > + > > + { > > + .name = "gva2gpa", > > + .args_type = "addr:l", > > + .params = "addr", > > + .help = "print the guest physical address corresponding to a guest virtual address", > > + .cmd = hmp_gva2gpa, > > + }, > > + > > +STEXI > > +@item gpa2hpa @var{addr} > > +@findex gpa2hpa > > s/gpa2hpa/gva2gpa/ > > Aside from this: > > Reviewed-by: Stefan Hajnoczi Queued -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK