Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DFD1C43219 for ; Wed, 1 May 2019 14:52:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75C8720866 for ; Wed, 1 May 2019 14:52:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726681AbfEAOwb (ORCPT ); Wed, 1 May 2019 10:52:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:55152 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726506AbfEAOwb (ORCPT ); Wed, 1 May 2019 10:52:31 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BBDDAACB8; Wed, 1 May 2019 14:52:29 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 33C121E3BEC; Wed, 1 May 2019 16:52:28 +0200 (CEST) Date: Wed, 1 May 2019 16:52:28 +0200 From: Jan Kara To: Linus Torvalds Cc: Jan Kara , linux-fsdevel Subject: Re: [GIT PULL] fsnotify fix for v5.1-rc8 Message-ID: <20190501145228.GB6024@quack2.suse.cz> References: <20190430214149.GA482@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue 30-04-19 15:10:30, Linus Torvalds wrote: > On Tue, Apr 30, 2019 at 2:41 PM Jan Kara wrote: > > > > to get a fix of user trigerable NULL pointer dereference syzbot has > > recently spotted. The problem has been introduced in rc1 so no CC stable is > > needed. > > Hmm. Pulled, but I thin kthe use of READ_ONCE/WRITE_ONCE is suspicious. > > If we're reading a pointer like this locklessly, the proper sequence > is almost always something like "smp_store_release()" to write the > pointer, and "smp_load_acquire()" to read it. > > Because that not only does the "access once" semantics, but it also > guarantees that when we actually look _through_ the pointer, we see > the data that was written to it. In contrast, code like this (from the > fix) > > + WRITE_ONCE(mark->connector, conn); > > ... > > + conn = READ_ONCE(iter_info->marks[type]->connector); > + /* Mark is just getting destroyed or created? */ > + if (!conn) > + continue; > + fsid = conn->fsid; > > is rather suspicious, because there's no obvious guarantee that tjhe > "conn->fsid" part was written on one CPU before we read it on another. Hum, you're right. The WRITE_ONCE(mark->connector, conn) still is not enough. It needs to have a barrier so that the connector initialization is guaranteed to be visible by RCU reader. READ_ONCE(iter_info->marks[type]->connector) is safe as is already contains smp_read_barrier_depends() which is all that should be needed once we have write barrier before WRITE_ONCE(). Since I don't think this is a practical problem, I'll just queue the fix for the merge window. Thanks for spotting this! Honza -- Jan Kara SUSE Labs, CR