Received: from eggs.gnu.org ([209.51.188.92]:58025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLsZJ-0001lB-It for qemu-devel@nongnu.org; Wed, 01 May 2019 12:58:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLsZG-0004vz-Fs for qemu-devel@nongnu.org; Wed, 01 May 2019 12:58:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47116) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLsZG-0004r3-93 for qemu-devel@nongnu.org; Wed, 01 May 2019 12:58:50 -0400 Date: Wed, 1 May 2019 13:58:41 -0300 From: Eduardo Habkost Message-ID: <20190501165841.GM28722@habkost.net> References: <20190426003652.32633-1-richardw.yang@linux.intel.com> <20190426003652.32633-2-richardw.yang@linux.intel.com> <20190430204636.GK28722@habkost.net> <20190430223618.lyl3ribm7gg5haa5@master> <20190430224816.GL28722@habkost.net> <20190430185011-mutt-send-email-mst@kernel.org> <86e00247-588c-37c1-0737-82614a8f18c0@redhat.com> <20190430193838-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190430193838-mutt-send-email-mst@kernel.org> Subject: Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Paolo Bonzini , Wei Yang , Wei Yang , pagupta@redhat.com, xiaoguangrong.eric@gmail.com, Haozhong Zhang , qemu-devel@nongnu.org, yi.z.zhang@linux.intel.com, yu.c.zhang@linux.intel.com, stefanha@redhat.com, imammedo@redhat.com, dan.j.williams@intel.com On Tue, Apr 30, 2019 at 07:38:59PM -0400, Michael S. Tsirkin wrote: > On Wed, May 01, 2019 at 01:11:34AM +0200, Paolo Bonzini wrote: > > On 01/05/19 00:50, Michael S. Tsirkin wrote: > > >> Stefan, did you hit a build failure, or it was just theoretical? > > >> > > >> linux-headers/*/mman.h is updated by "linux-headers: add > > >> linux/mman.h" (commit 8cf108c5d159). If the build really fails, > > >> something else is broken in our build system. > > > I think it's for non-linux hosts. linux-headers/ is only used > > > on linux hosts. > > > > Yes, it is. Maybe the #ifndef/#define part should be only used for > > non-Linux. > > > > Paolo > > Makes sense. We'd rather have an error on linux than stub it out as 0. I'm confused by these replies. When exactly do you expect an error on Linux? For context, I'm talking about the code in v14 of the series (which was already merged): #ifdef CONFIG_LINUX #include #else /* !CONFIG_LINUX */ #define MAP_SYNC 0x0 #define MAP_SHARED_VALIDATE 0x0 #endif /* CONFIG_LINUX */ I fail to see any case where the build would fail in v14. -- Eduardo