Received: from eggs.gnu.org ([209.51.188.92]:35020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMM4I-0005Jm-0L for qemu-devel@nongnu.org; Thu, 02 May 2019 20:28:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMM4H-0005ZH-6G for qemu-devel@nongnu.org; Thu, 02 May 2019 20:28:49 -0400 Received: from smtpbg302.qq.com ([184.105.206.27]:39751) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMM4G-0005Yl-VS for qemu-devel@nongnu.org; Thu, 02 May 2019 20:28:49 -0400 From: Cao Jiaxi Date: Fri, 3 May 2019 08:25:56 +0800 Message-Id: <20190503002556.9941-1-driver1998@foxmail.com> In-Reply-To: <20190503002258.9799-1-driver1998@foxmail.com> References: <20190503002258.9799-1-driver1998@foxmail.com> Subject: [Qemu-devel] [PATCH v3 2/4] qga: Fix mingw compilation warnings on enum conversion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mdroth@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org, Cao Jiaxi The win2qemu[] is supposed to be the conversion table to convert between STORAGE_BUS_TYPE in Windows SDK and GuestDiskBusType in qga. But it was incorrectly written that it forces to set a GuestDiskBusType value to STORAGE_BUS_TYPE, which generates an enum conversion warning in clang. Signed-off-by: Cao Jiaxi --- qga/commands-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index d40d61f605..6b67f16faf 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -457,7 +457,7 @@ void qmp_guest_file_flush(int64_t handle, Error **errp) #ifdef CONFIG_QGA_NTDDSCSI -static STORAGE_BUS_TYPE win2qemu[] = { +static GuestDiskBusType win2qemu[] = { [BusTypeUnknown] = GUEST_DISK_BUS_TYPE_UNKNOWN, [BusTypeScsi] = GUEST_DISK_BUS_TYPE_SCSI, [BusTypeAtapi] = GUEST_DISK_BUS_TYPE_IDE, -- 2.17.1