From: joeyli Subject: Re: [PATCH 1/2 v2] efi: add a function to convert the status value to string Date: Fri, 3 May 2019 16:01:16 +0800 Message-ID: <20190503080116.GO11486@linux-l9pv.suse> References: <20190502040441.30372-1-jlee@suse.com> <20190503061518.GM11486@linux-l9pv.suse> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ard Biesheuvel Cc: "Lee, Chun-Yi" , James Morris , "Serge E . Hallyn" , David Howells , Josh Boyer , Nayna Jain , Mimi Zohar , linux-efi , linux-security-module , Linux Kernel Mailing List , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck List-Id: linux-efi@vger.kernel.org On Fri, May 03, 2019 at 08:16:42AM +0200, Ard Biesheuvel wrote: > On Fri, 3 May 2019 at 08:15, joeyli wrote: > > > > On Thu, May 02, 2019 at 10:53:31AM +0200, Ard Biesheuvel wrote: > > > On Thu, 2 May 2019 at 06:04, Lee, Chun-Yi wrote: > > > > > > > > This function can be used to convert EFI status value to string > > > > for printing out debug message. Using this function can improve > > > > the readability of log. > > > > > > > > v2. > > > > > > Please move the changelog out of the commit log (move it below the --- > > > further down) > > > > > > > OK! I will moved the changelog out of the commit log. > > > > > > - Changed the wording in subject and description. > > > > - Moved the marco immediately after the status value definitions. > > > > - Turned into a proper function instead of inline. > > > > > > > > > > You missed my point here. A proper function means the function in a .c > > > file, and only the declaration in a .h file. This way, you are still > > > duplicating the literal strings into every object file that references > > > this function. > > > > > > > Sorry for I missunderstood. I will move the function to load_uefi.c. > > > > No, please move it to a file that is shared between all EFI code. I see! I will move the function to the position that it is just behind efi_status_to_str() in drivers/firmware/efi/efi.c. Please let me know if the position is not suitable. Thanks a lot! Joey Lee