Received: from eggs.gnu.org ([209.51.188.92]:36694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMaR0-0001GR-9d for qemu-devel@nongnu.org; Fri, 03 May 2019 11:49:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMaQz-00021X-6j for qemu-devel@nongnu.org; Fri, 03 May 2019 11:49:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43176) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMaQz-000204-17 for qemu-devel@nongnu.org; Fri, 03 May 2019 11:49:13 -0400 Date: Fri, 3 May 2019 16:49:05 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20190503154905.GJ17905@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20190503154613.4192-1-kchamart@redhat.com> <20190503154613.4192-2-kchamart@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190503154613.4192-2-kchamart@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] VirtIO-RNG: Update default entropy source to `/dev/urandom` List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kashyap Chamarthy Cc: qemu-devel@nongnu.org, amit@kernel.org, armbru@redhat.com, rjones@redhat.com On Fri, May 03, 2019 at 05:46:13PM +0200, Kashyap Chamarthy wrote: > When QEMU exposes a VirtIO-RNG device to the guest, that device needs a > source of entropy, and that source needs to be "non-blocking", like > `/dev/urandom`. However, currently QEMU defaults to the problematic > `/dev/random`, which is "blocking" (as in, it waits until sufficient > entropy is available). >=20 > So change the entropy source to the recommended `/dev/urandom`. >=20 > Related discussion in these[1][2] past threads. >=20 > [1] https://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg08335.h= tml > -- "RNG: Any reason QEMU doesn't default to `/dev/urandom`?" > [2] https://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg02724.h= tml > -- "[RFC] Virtio RNG: Consider changing the default entropy source = to > /dev/urandom" >=20 > Signed-off-by: Kashyap Chamarthy > --- > backends/rng-random.c | 2 +- > qemu-options.hx | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrang=C3=A9 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|