From: Tom Rini Date: Sun, 5 May 2019 08:50:49 -0400 Subject: [U-Boot] [PATCH 1/1] env: Exit tools when invalid CRC found In-Reply-To: <7f3c6ea239a26e247c43d1ddf6698f9f43973f76.camel@idexx.com> References: <7f3c6ea239a26e247c43d1ddf6698f9f43973f76.camel@idexx.com> Message-ID: <20190505125049.GJ31207@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Apr 03, 2019 at 01:30:47PM +0000, Molloy, Philip wrote: > fw_setenv and fw_printenv currently print a warning and use a default > environment compiled into the binary when an invalid CRC is found. This > modifies the default behavior to print an error and exit. This is > especially important when calling the tools from a script since the > script depends on the exit code of the tool to know something went > wrong. > > If the default environment is desired it should be read explicitly by > the caller. A better model is to store a default environment as a > separate binary or text file rather than storing it in the executable. > > Signed-off-by: Philip Molloy Conceptually, yes, this is correct. However, the behavior in question has been deployed for so long that I don't feel that we can change it at this point, so I'm going to NAK this. Sorry. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: