Received: from list by lists.gnu.org with archive (Exim 4.71) id 1hNLvw-0003Xm-1Y for mharc-qemu-trivial@gnu.org; Sun, 05 May 2019 14:32:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNLvt-0003Vo-Gc for qemu-trivial@nongnu.org; Sun, 05 May 2019 14:32:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNLvs-0006b1-Et for qemu-trivial@nongnu.org; Sun, 05 May 2019 14:32:17 -0400 Received: from 20.mo4.mail-out.ovh.net ([46.105.33.73]:49444) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNLvs-0006UZ-82 for qemu-trivial@nongnu.org; Sun, 05 May 2019 14:32:16 -0400 Received: from player779.ha.ovh.net (unknown [10.108.42.228]) by mo4.mail-out.ovh.net (Postfix) with ESMTP id EC34A1E62F0 for ; Sun, 5 May 2019 20:32:12 +0200 (CEST) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player779.ha.ovh.net (Postfix) with ESMTPSA id 4A944550F33C; Sun, 5 May 2019 18:32:10 +0000 (UTC) Date: Sun, 5 May 2019 20:32:08 +0200 From: Greg Kurz To: Thomas Huth Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org Message-ID: <20190505203208.684776c0@bahia.lan> In-Reply-To: <20190505144527.27926-1-thuth@redhat.com> References: <20190505144527.27926-1-thuth@redhat.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 3182919040220830002 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrjeehgddufeefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 46.105.33.73 Subject: Re: [Qemu-trivial] [PATCH] virtfs: Add missing "id" parameter in documentation X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 May 2019 18:32:18 -0000 Hi Thomas, Thanks for the janitoring :) On Sun, 5 May 2019 16:45:27 +0200 Thomas Huth wrote: > ... and remove the square brackets from "path" and "security_model", > since these parameters are not optional. > Well this is only true when fsdriver == local, but the other fs drivers, ie. proxy and synth, don't need it at all. Each driver has its own set of options actually. This should better be described with separate lines IMHO. Also, it should be stated that "id" relates to the fs backend, ie. it belongs to the -fsdev "id" space, not to the device that gets exposed to the guest. Cheers, -- Greg > Buglink: https://bugs.launchpad.net/qemu/+bug/1581976 > Signed-off-by: Thomas Huth > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 51802cbb26..9571ddd141 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -1311,7 +1311,7 @@ DEF("virtfs", HAS_ARG, QEMU_OPTION_virtfs, > > STEXI > > -@item -virtfs @var{fsdriver}[,path=@var{path}],mount_tag=@var{mount_tag}[,security_model=@var{security_model}][,writeout=@var{writeout}][,readonly][,socket=@var{socket}|sock_fd=@var{sock_fd}][,fmode=@var{fmode}][,dmode=@var{dmode}] > +@item -virtfs @var{fsdriver},path=@var{path},mount_tag=@var{mount_tag},security_model=@var{security_model}[,id=@var{id}][,writeout=@var{writeout}][,readonly][,socket=@var{socket}|sock_fd=@var{sock_fd}][,fmode=@var{fmode}][,dmode=@var{dmode}] > @findex -virtfs > > The general form of a Virtual File system pass-through options are: