Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54678C04A6B for ; Fri, 10 May 2019 17:04:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1266A2084E for ; Fri, 10 May 2019 17:04:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1266A2084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:47063 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP8x4-00064o-8z for qemu-devel@archiver.kernel.org; Fri, 10 May 2019 13:04:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP8vl-0005D7-PI for qemu-devel@nongnu.org; Fri, 10 May 2019 13:03:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hP8vk-0005Cc-Ct for qemu-devel@nongnu.org; Fri, 10 May 2019 13:03:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43768) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hP8vk-0005CC-4Q for qemu-devel@nongnu.org; Fri, 10 May 2019 13:03:32 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 650D3C4EA9 for ; Fri, 10 May 2019 17:03:31 +0000 (UTC) Received: from localhost (ovpn-116-40.gru2.redhat.com [10.97.116.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id E74CF5ED34; Fri, 10 May 2019 17:03:30 +0000 (UTC) Date: Fri, 10 May 2019 14:03:28 -0300 From: Eduardo Habkost To: Markus Armbruster Message-ID: <20190510170328.GR4189@habkost.net> References: <87imumj1jb.fsf@dusky.pond.sub.org> <20190507161845.GL28722@habkost.net> <87lfzh5mrh.fsf@dusky.pond.sub.org> <20190508202830.GF4189@habkost.net> <874l646nbh.fsf@dusky.pond.sub.org> <20190509091452.GF31299@redhat.com> <20190509155247.GJ4189@habkost.net> <20190509160811.GL31299@redhat.com> <20190509174432.GM4189@habkost.net> <874l62x1qj.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <874l62x1qj.fsf@dusky.pond.sub.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 10 May 2019 17:03:31 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mprivozn@redhat.com, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , qemu-devel@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, May 10, 2019 at 08:28:04AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: >=20 > > On Thu, May 09, 2019 at 05:08:11PM +0100, Daniel P. Berrang=E9 wrote: > >> On Thu, May 09, 2019 at 12:52:47PM -0300, Eduardo Habkost wrote: > >> > On Thu, May 09, 2019 at 10:14:52AM +0100, Daniel P. Berrang=E9 wro= te: > >> > > On Thu, May 09, 2019 at 10:31:46AM +0200, Markus Armbruster wrot= e: > >> > > > We've wandered into the QAPI vs. QOM swamp. Cc: Paolo. > >> > > >=20 > >> > > > Eduardo Habkost writes: > >> > > >=20 > >> > > > > On Wed, May 08, 2019 at 11:16:50AM +0200, Markus Armbruster = wrote: > [...] > >> > > > >> I agree we should point to a preferred replacement whenever= we deprecate > >> > > > >> something. > >> > > > >>=20 > >> > > > >> We have to do it in documentation. And we generally do, in > >> > > > >> qemu-deprecated.texi. > >> > > > >>=20 > >> > > > >> How useful would doing it in QMP as well be? Depends on wh= at management > >> > > > >> applications can do with the additional information. > >> > > > > > >> > > > > I expect it to be useful for things that have obvious > >> > > > > replacements, like old machine type or CPU model versions. > >> > > >=20 > >> > > > I doubt a management application should apply suggested replac= ements > >> > > > automatically, and I doubt libvirt would. Not even when QEMU = developers > >> > > > deem them "obvious". > >> > >=20 > >> > > We certainly won't apply the suggested replacement as in many ca= ses > >> > > it is not going to be a functionally equivalent drop-in. > >> >=20 > >> > Who's "we"? > >>=20 > >> I was refering to libvirt here. > >>=20 > >> > > If QEMU logs it to stderr, it will end up in the per-VM log file > >> > > libvirt has under /var/log/libvirt/qemu/$GUESTNAME.log. If QEMU > >> > > doesn't log it to stderr, then libvirt would just write it to > >> > > that same log file itself. > >> > >=20 > >> > > If libvirt gains some API or event for notifying apps of depreca= tion > >> > > we might bubble it up to the mgmt app that way. > >> > >=20 > >> > > I still feel it is useful to have the suggested replacement in t= he > >> > > logs, rather than only leaving it in qemu-deprecated.texi. Thi= s > >> > > way the info is immediately visible to both app developers and a= ny > >> > > support person dealing with bugs. > >> > >=20 > >> > > If the app dev see the suggested replacement upfront they're mor= e > >> > > likely to make an immediate decision to update their code if the > >> > > suggestion is trivial. If they need to go find the QEMU docs to > >> > > lookup what action is required I feel they'll more likely just > >> > > put the item on their long todo list where it will languish. > >> >=20 > >> > Agreed. However, note that the audience for deprecation > >> > information is not just developers and support people. End users > >> > need to know when they are relying on a deprecated feature, and > >> > applications should make it as easy as possible for them to > >> > update their configurations. > >> >=20 > >> > I'm not suggesting the alternative would be applied > >> > automatically. But having the alternative available in a > >> > machine-friendly way may be the difference between a unhelpful UI > >> > that just tells the user there's some problem but can't give a > >> > solution, and one that can really assist the user to fix the > >> > problem. > >>=20 > >> For some aspects of QEMU it might be possible, but considering the > >> broader set of things which can be deprecated, I don't think it is > >> possible to expose a machine consumable "suggestion". > >>=20 > >> Consider the deprecation of the ACL feature. We deprecated monitor > >> commands "acl_add", "acl_policy", "acl_reset", etc. The suggested > >> replacement is to use one of the many possible QAuthZ types combined > >> with the -object arg. Even if we invented some way to express this > >> in the schema, I don't think any app would usefully consume it. > > > > No problem, we don't need to suggest a machine consumable > > alternative for everything. >=20 > Sure, but we need to get enough value out of it to justify its cost. >=20 > > I'm thinking about features that are visible to the end user and > > require user action to fix their configuration, like machine type > > versions or CPU model versions. >=20 > Even those may need translation as we cross layers of the stack. >=20 > The fewer cases we have where the machinery for machine-readable > deprecation advice is actually useful, the worse its cost / benefit > ratio is going to be. Are you arguing the cost is unreasonably large? I still don't see what the problem is, here. --=20 Eduardo