Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5F9EC04A6B for ; Fri, 10 May 2019 20:32:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0A4B20850 for ; Fri, 10 May 2019 20:32:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0A4B20850 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:49569 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPCCQ-0000wh-Ul for qemu-devel@archiver.kernel.org; Fri, 10 May 2019 16:32:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPCBc-0000UI-NX for qemu-devel@nongnu.org; Fri, 10 May 2019 16:32:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPCBb-0006Q0-P8 for qemu-devel@nongnu.org; Fri, 10 May 2019 16:32:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45026) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hPCBb-0006K1-Jk for qemu-devel@nongnu.org; Fri, 10 May 2019 16:32:07 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 63136309B16C; Fri, 10 May 2019 20:32:05 +0000 (UTC) Received: from localhost (ovpn-116-40.gru2.redhat.com [10.97.116.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id D51561001E78; Fri, 10 May 2019 20:32:04 +0000 (UTC) Date: Fri, 10 May 2019 17:32:03 -0300 From: Eduardo Habkost To: Jiri Denemark Message-ID: <20190510203203.GW4189@habkost.net> References: <20190422234742.15780-1-ehabkost@redhat.com> <20190509133537.GK7181@orkuz.int.mamuti.net> <20190509135617.GH4189@habkost.net> <20190509180603.424c8277@Igors-MacBook-Pro> <20190509163618.GN7181@orkuz.int.mamuti.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190509163618.GN7181@orkuz.int.mamuti.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 10 May 2019 20:32:05 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov , Richard Henderson , qemu-devel@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, May 09, 2019 at 06:36:18PM +0200, Jiri Denemark wrote: > On Thu, May 09, 2019 at 18:06:03 +0200, Igor Mammedov wrote: > > On Thu, 9 May 2019 10:56:17 -0300 > > Eduardo Habkost wrote: > > > > > On Thu, May 09, 2019 at 03:35:37PM +0200, Jiri Denemark wrote: > > > > Would this unavailable-features property contain only canonical names of > > > > the features or all possible aliases of all features? For example, > > > > "tsc-adjust" can also be spelled as "tsc_adjust". When calling > > > > query-cpu-model-expansion, we have a way to request all variants by > > > > running full expansion on the result of a previous static expansion. Can > > > > we get something like this for unavailable-features too? > > > > > > I'd like to avoid that, and refer only to the canonical names. > > > > Can we deprecate aliases to avoid confusion in future? > > (there aren't that many of them that used pre-QOM name format) > > If you come up with a way libvirt could use to detect which name it > should use when talking to QEMU... The property names are part of the API, and deprecation would just be documented in the QEMU documentation. Why would you need to enumerate them dynamically at runtime? -- Eduardo