Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 089C8C04AA7 for ; Mon, 13 May 2019 16:32:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4E40208CA for ; Mon, 13 May 2019 16:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729539AbfEMQch (ORCPT ); Mon, 13 May 2019 12:32:37 -0400 Received: from orbyte.nwl.cc ([151.80.46.58]:45956 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728664AbfEMQch (ORCPT ); Mon, 13 May 2019 12:32:37 -0400 Received: from localhost ([::1]:59046 helo=tatos) by orbyte.nwl.cc with esmtp (Exim 4.91) (envelope-from ) id 1hQDsR-00058y-7X; Mon, 13 May 2019 18:32:35 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: [iptables PATCH] xtables: Fix for explicit rule flushes Date: Mon, 13 May 2019 18:32:37 +0200 Message-Id: <20190513163237.4656-1-phil@nwl.cc> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org The commit this fixes added a new parameter to __nft_rule_flush() to mark a rule flush job as implicit or not. Yet the code added to that function ignores the parameter and instead always sets batch job's 'implicit' flag to 1. Fixes: 77e6a93d5c9dc ("xtables: add and set "implict" flag on transaction objects") Signed-off-by: Phil Sutter --- iptables/nft.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iptables/nft.c b/iptables/nft.c index 3e8f2d501d0c5..f25ab032712fc 100644 --- a/iptables/nft.c +++ b/iptables/nft.c @@ -1698,7 +1698,7 @@ __nft_rule_flush(struct nft_handle *h, const char *table, return; } - obj->implicit = 1; + obj->implicit = implicit; } int nft_rule_flush(struct nft_handle *h, const char *chain, const char *table, -- 2.21.0