From: Thomas Petazzoni Date: Wed, 15 May 2019 11:50:26 +0200 Subject: [Buildroot] [PATCH 1/1] package/brotli: fix build on microblaze with -02 In-Reply-To: References: <20190514211526.26467-1-fontaine.fabrice@gmail.com> <20190515122718.GB6334@momiji> Message-ID: <20190515115026.5a5b6632@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Wed, 15 May 2019 11:42:12 +0200 Giulio Benetti wrote: > >> +# prevents from triggering GCC ICE > >> +# A bug was reported to the gcc bug tracker: > >> +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485 > >> +ifeq ($(BR2_microblaze),y) > >> +BROTLI_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -O0" > >> +endif > > > > This is not a great fix, but still better than not being able to build the > > package at all, so I think it's okay to merge it. ?\_(?)_/? > > This is another package added to the list of Microblaze GCC6/7 bug 85180. Be careful: we have two separate issues. Gcc bug 85180 and gcc bug 68485. gcc bug 85180, which you were working on, causes the compiler to got in an infinite loop gcc bug 68485, which this patch is about, causes the compiler to throw an ICE (Internal Compiler Error). I.e the compiler aborts, it does not enter in an infinite loop. It would be interesting to see if bug 68485 stills exists with gcc 8.x or 9.x. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com