From: Eric Biggers Subject: Re: [PATCH] f2fs-tools: improve xattr value printing Date: Wed, 15 May 2019 08:48:48 -0700 Message-ID: <20190515154846.GA21903@sol.localdomain> References: <20190424175730.70979-1-ebiggers@kernel.org> <242d8b26-592b-57da-bd1f-3466bf714803@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hQw9X-0007Rs-Ru for linux-f2fs-devel@lists.sourceforge.net; Wed, 15 May 2019 15:49:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hQw9V-00HMjA-Pi for linux-f2fs-devel@lists.sourceforge.net; Wed, 15 May 2019 15:49:11 +0000 Content-Disposition: inline In-Reply-To: <242d8b26-592b-57da-bd1f-3466bf714803@huawei.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net On Sun, Apr 28, 2019 at 02:25:10PM +0800, Chao Yu wrote: > On 2019/4/25 1:57, Eric Biggers wrote: > > From: Eric Biggers > > > > - Print the values of xattrs that have an unknown ->e_name_index, rather > > than ignoring them. > > > > - Replace char with u8. Otherwise xattr values containing bytes >= 0x80 > > are printed incorrectly on platforms where char is signed. > > > > - Only parse the encryption xattr if it has a known format number and > > size. Otherwise print it as hex. > > > > - Remove incorrect le16_to_cpu() on ->e_name_len which has type u8. > > > > - Consolidate the code that prints the xattr value as hex. > > > > - Constify pointers to the xattr entry. > > > > Signed-off-by: Eric Biggers > > Reviewed-by: Chao Yu > > Thanks, > Hi Jaegeuk, are you planning to apply this patch? Thanks, - Eric