Date: Wed, 15 May 2019 21:08:27 +0200 (CEST) Message-Id: <201905151908.x4FJ8RRT035404@...2054...> From: Gert Doering In-Reply-To: <20190514081159.12192-1-a@...2181...> References: <20190514081159.12192-1-a@...2181...> Subject: [Openvpn-devel] [PATCH applied] Re: implement platform generic networking API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Antonio Quartulli Cc: openvpn-devel@lists.sourceforge.net Acked-by: Gert Doering This patch does not actually *do* anything - it just brings in a new file (networking.h) with the new API. The file wouldn't compile because it references not-yet-existing other .h files, so the patch is a bit confusing - but since the rest of the series has ACKs and needs this prequel, here we go. Your patch has been applied to the master branch. Note: I think "networking.h" and "networking_iproute2.h" are very long file names (and are hurting my sense for aesthetics) so I suggest we rename those to "net.h" and "net_.h" afterwards - not the most elegant approach but I do not want to hold up the series any longer. Note2: when this is in, I want us to drop support for ifconfig/route on Linux, and get rid of --enable-iproute2 (this would become the fallback if --enable-sitnl is not set). Two options are enough. commit 3d26593736982852fcf277b541da38b4c3cc7fc8 Author: Antonio Quartulli Date: Tue May 14 10:11:59 2019 +0200 implement platform generic networking API Signed-off-by: Antonio Quartulli Acked-by: Gert Doering Message-Id: <20190514081159.12192-1-a@...2181...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18458.html Signed-off-by: Gert Doering -- kind regards, Gert Doering