From: Olaf Hering Subject: Re: [PATCH v1] libxl: fix device_model_version related assert Date: Thu, 16 May 2019 15:54:55 +0200 Message-ID: <20190516155455.3a97d2fb.olaf@aepfle.de> References: <20190516125000.23559-1-olaf@aepfle.de> <20190516133013.GG2798@zion.uk.xensource.com> <20190516153601.45352e5c.olaf@aepfle.de> <20190516134653.GI2798@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0219521692336972873==" Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hRGqj-0001zU-K8 for xen-devel@lists.xenproject.org; Thu, 16 May 2019 13:55:10 +0000 In-Reply-To: <20190516134653.GI2798@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Wei Liu Cc: xen-devel@lists.xenproject.org, Ian Jackson List-Id: xen-devel@lists.xenproject.org --===============0219521692336972873== Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/8C8J+1NO6Ytas=LcTPFwKSr"; protocol="application/pgp-signature" --Sig_/8C8J+1NO6Ytas=LcTPFwKSr Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 16 May 2019 14:46:53 +0100 schrieb Wei Liu : > Can you clarify? create_domain has a libxl_domain_config on its stack. This is passed to freemem, and libxl_domain_need_memory modifies it as needed. The modification will go through libxl_domain_create_new, do_domain_create, initiate_domain_create to libxl__domain_set_device_model. This function will return right away because device_model_version is already set. Olaf --Sig_/8C8J+1NO6Ytas=LcTPFwKSr Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCXN1rrwAKCRBdQqD6ppg2 flnKAJ9xLWmgjodnKsd5brrs/MSWWpBh5QCfS2nO2CEK1H5T9M19nczXUAXPI/U= =j4o/ -----END PGP SIGNATURE----- --Sig_/8C8J+1NO6Ytas=LcTPFwKSr-- --===============0219521692336972873== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============0219521692336972873==--