From: Daniel Vetter Subject: Re: [PATCH v2 1/3] drm/gem: Rename drm_gem_dumb_map_offset() to drm_gem_map_offset() Date: Thu, 16 May 2019 22:25:37 +0200 Message-ID: <20190516202537.GD3851@phenom.ffwll.local> References: <20190516141447.46839-1-steven.price@arm.com> <20190516141447.46839-2-steven.price@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2664E894EB for ; Thu, 16 May 2019 20:25:42 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id b8so6996691edm.11 for ; Thu, 16 May 2019 13:25:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190516141447.46839-2-steven.price@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Steven Price Cc: Tomeu Vizoso , David Airlie , Seung-Woo Kim , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Maxime Ripard , Kyungmin Park , Kukjin Kim , dri-devel@lists.freedesktop.org, Sean Paul , Alyssa Rosenzweig List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXkgMTYsIDIwMTkgYXQgMDM6MTQ6NDVQTSArMDEwMCwgU3RldmVuIFByaWNlIHdy b3RlOgo+IGRybV9nZW1fZHVtYl9tYXBfb2Zmc2V0KCkgaXMgYSB1c2VmdWwgaGVscGVyIGZvciBu b24tZHVtYiBjbGllbnRzLCBzbwo+IHJlbmFtZSBpdCB0byByZW1vdmUgdGhlIF9kdW1iLgo+IAo+ IFNpZ25lZC1vZmYtYnk6IFN0ZXZlbiBQcmljZSA8c3RldmVuLnByaWNlQGFybS5jb20+CgpSZXZp ZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9kcm1fZHVtYl9idWZmZXJzLmMgICAgICB8IDQgKystLQo+ICBkcml2 ZXJzL2dwdS9kcm0vZHJtX2dlbS5jICAgICAgICAgICAgICAgfCA2ICsrKy0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZ2VtLmMgfCAzICstLQo+ICBpbmNsdWRlL2RybS9k cm1fZ2VtLmggICAgICAgICAgICAgICAgICAgfCA0ICsrLS0KPiAgNCBmaWxlcyBjaGFuZ2VkLCA4 IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9kcm1fZHVtYl9idWZmZXJzLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2R1bWJfYnVm ZmVycy5jCj4gaW5kZXggODFkZmRkMzM3NTNhLi45NTY2NjU0NjQyOTYgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2RybV9kdW1iX2J1ZmZlcnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fZHVtYl9idWZmZXJzLmMKPiBAQCAtNDYsNyArNDYsNyBAQAo+ICAgKiBUbyBzdXBwb3J0 IGR1bWIgb2JqZWN0cyBkcml2ZXJzIG11c3QgaW1wbGVtZW50IHRoZSAmZHJtX2RyaXZlci5kdW1i X2NyZWF0ZQo+ICAgKiBvcGVyYXRpb24uICZkcm1fZHJpdmVyLmR1bWJfZGVzdHJveSBkZWZhdWx0 cyB0byBkcm1fZ2VtX2R1bWJfZGVzdHJveSgpIGlmCj4gICAqIG5vdCBzZXQgYW5kICZkcm1fZHJp dmVyLmR1bWJfbWFwX29mZnNldCBkZWZhdWx0cyB0bwo+IC0gKiBkcm1fZ2VtX2R1bWJfbWFwX29m ZnNldCgpLiBTZWUgdGhlIGNhbGxiYWNrcyBmb3IgZnVydGhlciBkZXRhaWxzLgo+ICsgKiBkcm1f Z2VtX21hcF9vZmZzZXQoKS4gU2VlIHRoZSBjYWxsYmFja3MgZm9yIGZ1cnRoZXIgZGV0YWlscy4K PiAgICoKPiAgICogTm90ZSB0aGF0IGR1bWIgb2JqZWN0cyBtYXkgbm90IGJlIHVzZWQgZm9yIGdw dSBhY2NlbGVyYXRpb24sIGFzIGhhcyBiZWVuCj4gICAqIGF0dGVtcHRlZCBvbiBzb21lIEFSTSBl bWJlZGRlZCBwbGF0Zm9ybXMuIFN1Y2ggZHJpdmVycyByZWFsbHkgbXVzdCBoYXZlCj4gQEAgLTEy NSw3ICsxMjUsNyBAQCBpbnQgZHJtX21vZGVfbW1hcF9kdW1iX2lvY3RsKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsCj4gIAkJCQkJCSAgICBhcmdzLT5oYW5kbGUsCj4gIAkJCQkJCSAgICAmYXJncy0+ b2Zmc2V0KTsKPiAgCWVsc2UKPiAtCQlyZXR1cm4gZHJtX2dlbV9kdW1iX21hcF9vZmZzZXQoZmls ZV9wcml2LCBkZXYsIGFyZ3MtPmhhbmRsZSwKPiArCQlyZXR1cm4gZHJtX2dlbV9tYXBfb2Zmc2V0 KGZpbGVfcHJpdiwgZGV2LCBhcmdzLT5oYW5kbGUsCj4gIAkJCQkJICAgICAgICZhcmdzLT5vZmZz ZXQpOwo+ICB9Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jIGIv ZHJpdmVycy9ncHUvZHJtL2RybV9nZW0uYwo+IGluZGV4IDUwZGUxMzhjODllMC4uOTliYjdmNzlh NzBiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX2dlbS5jCj4gQEAgLTI5NCw3ICsyOTQsNyBAQCBkcm1fZ2VtX2hhbmRs ZV9kZWxldGUoc3RydWN0IGRybV9maWxlICpmaWxwLCB1MzIgaGFuZGxlKQo+ICBFWFBPUlRfU1lN Qk9MKGRybV9nZW1faGFuZGxlX2RlbGV0ZSk7Cj4gIAo+ICAvKioKPiAtICogZHJtX2dlbV9kdW1i X21hcF9vZmZzZXQgLSByZXR1cm4gdGhlIGZha2UgbW1hcCBvZmZzZXQgZm9yIGEgZ2VtIG9iamVj dAo+ICsgKiBkcm1fZ2VtX21hcF9vZmZzZXQgLSByZXR1cm4gdGhlIGZha2UgbW1hcCBvZmZzZXQg Zm9yIGEgZ2VtIG9iamVjdAo+ICAgKiBAZmlsZTogZHJtIGZpbGUtcHJpdmF0ZSBzdHJ1Y3R1cmUg Y29udGFpbmluZyB0aGUgZ2VtIG9iamVjdAo+ICAgKiBAZGV2OiBjb3JyZXNwb25kaW5nIGRybV9k ZXZpY2UKPiAgICogQGhhbmRsZTogZ2VtIG9iamVjdCBoYW5kbGUKPiBAQCAtMzA2LDcgKzMwNiw3 IEBAIEVYUE9SVF9TWU1CT0woZHJtX2dlbV9oYW5kbGVfZGVsZXRlKTsKPiAgICogUmV0dXJuczoK PiAgICogMCBvbiBzdWNjZXNzIG9yIGEgbmVnYXRpdmUgZXJyb3IgY29kZSBvbiBmYWlsdXJlLgo+ ICAgKi8KPiAtaW50IGRybV9nZW1fZHVtYl9tYXBfb2Zmc2V0KHN0cnVjdCBkcm1fZmlsZSAqZmls ZSwgc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAraW50IGRybV9nZW1fbWFwX29mZnNldChzdHJ1 Y3QgZHJtX2ZpbGUgKmZpbGUsIHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCSAgICB1MzIg aGFuZGxlLCB1NjQgKm9mZnNldCkKPiAgewo+ICAJc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmo7 Cj4gQEAgLTMzMiw3ICszMzIsNyBAQCBpbnQgZHJtX2dlbV9kdW1iX21hcF9vZmZzZXQoc3RydWN0 IGRybV9maWxlICpmaWxlLCBzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAKPiAgCXJldHVybiBy ZXQ7Cj4gIH0KPiAtRVhQT1JUX1NZTUJPTF9HUEwoZHJtX2dlbV9kdW1iX21hcF9vZmZzZXQpOwo+ ICtFWFBPUlRfU1lNQk9MX0dQTChkcm1fZ2VtX21hcF9vZmZzZXQpOwo+ICAKPiAgLyoqCj4gICAq IGRybV9nZW1fZHVtYl9kZXN0cm95IC0gZHVtYiBmYiBjYWxsYmFjayBoZWxwZXIgZm9yIGdlbSBi YXNlZCBkcml2ZXJzCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9z X2RybV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9nZW0uYwo+IGlu ZGV4IGE1NWY1YWM0MWJmMy4uNWUzYWE5ZTRhMDk2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9leHlub3MvZXh5bm9zX2RybV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9leHlu b3MvZXh5bm9zX2RybV9nZW0uYwo+IEBAIC0yNzYsOCArMjc2LDcgQEAgaW50IGV4eW5vc19kcm1f Z2VtX21hcF9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICB7Cj4g IAlzdHJ1Y3QgZHJtX2V4eW5vc19nZW1fbWFwICphcmdzID0gZGF0YTsKPiAgCj4gLQlyZXR1cm4g ZHJtX2dlbV9kdW1iX21hcF9vZmZzZXQoZmlsZV9wcml2LCBkZXYsIGFyZ3MtPmhhbmRsZSwKPiAt CQkJCSAgICAgICAmYXJncy0+b2Zmc2V0KTsKPiArCXJldHVybiBkcm1fZ2VtX21hcF9vZmZzZXQo ZmlsZV9wcml2LCBkZXYsIGFyZ3MtPmhhbmRsZSwgJmFyZ3MtPm9mZnNldCk7Cj4gIH0KPiAgCj4g IHN0cnVjdCBleHlub3NfZHJtX2dlbSAqZXh5bm9zX2RybV9nZW1fZ2V0KHN0cnVjdCBkcm1fZmls ZSAqZmlscCwKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2dlbS5oIGIvaW5jbHVkZS9k cm0vZHJtX2dlbS5oCj4gaW5kZXggNTA0N2M3ZWUyNWY1Li45MWIwN2MyMzI1ZTkgMTAwNjQ0Cj4g LS0tIGEvaW5jbHVkZS9kcm0vZHJtX2dlbS5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2dlbS5o Cj4gQEAgLTM5NSw4ICszOTUsOCBAQCBpbnQgZHJtX2dlbV9mZW5jZV9hcnJheV9hZGQoc3RydWN0 IHhhcnJheSAqZmVuY2VfYXJyYXksCj4gIGludCBkcm1fZ2VtX2ZlbmNlX2FycmF5X2FkZF9pbXBs aWNpdChzdHJ1Y3QgeGFycmF5ICpmZW5jZV9hcnJheSwKPiAgCQkJCSAgICAgc3RydWN0IGRybV9n ZW1fb2JqZWN0ICpvYmosCj4gIAkJCQkgICAgIGJvb2wgd3JpdGUpOwo+IC1pbnQgZHJtX2dlbV9k dW1iX21hcF9vZmZzZXQoc3RydWN0IGRybV9maWxlICpmaWxlLCBzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LAo+IC0JCQkgICAgdTMyIGhhbmRsZSwgdTY0ICpvZmZzZXQpOwo+ICtpbnQgZHJtX2dlbV9t YXBfb2Zmc2V0KHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwgc3RydWN0IGRybV9kZXZpY2UgKmRldiwK PiArCQkgICAgICAgdTMyIGhhbmRsZSwgdTY0ICpvZmZzZXQpOwo+ICBpbnQgZHJtX2dlbV9kdW1i X2Rlc3Ryb3koc3RydWN0IGRybV9maWxlICpmaWxlLAo+ICAJCQkgc3RydWN0IGRybV9kZXZpY2Ug KmRldiwKPiAgCQkJIHVpbnQzMl90IGhhbmRsZSk7Cj4gLS0gCj4gMi4yMC4xCj4gCgotLSAKRGFu aWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Js b2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs