From: Greg Kurz Date: Mon, 20 May 2019 09:23:43 +0000 Subject: Re: [PATCH 3/3] KVM: PPC: Book3S HV: XIVE: fix the enforced limit on the vCPU identifier Message-Id: <20190520112343.7e724abb@bahia.lan> List-Id: References: <20190520071514.9308-1-clg@kaod.org> <20190520071514.9308-4-clg@kaod.org> In-Reply-To: <20190520071514.9308-4-clg@kaod.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: =?UTF-8?B?Q8OpZHJpYw==?= Le Goater Cc: kvm-ppc@vger.kernel.org, Paul Mackerras , David Gibson , kvm@vger.kernel.org, Satheesh Rajendran On Mon, 20 May 2019 09:15:14 +0200 Cédric Le Goater wrote: > When a vCPU is connected to the KVM device, it is done using its vCPU > identifier in the guest. Fix the enforced limit on the vCPU identifier > by taking into account the SMT mode. > Reviewed-by: Greg Kurz > Reported-by: Satheesh Rajendran > Tested-by: Satheesh Rajendran > Signed-off-by: Cédric Le Goater > --- > arch/powerpc/kvm/book3s_xive_native.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kvm/book3s_xive_native.c b/arch/powerpc/kvm/book3s_xive_native.c > index 3fdea6bf4e97..25b6b0e2d02a 100644 > --- a/arch/powerpc/kvm/book3s_xive_native.c > +++ b/arch/powerpc/kvm/book3s_xive_native.c > @@ -109,7 +109,7 @@ int kvmppc_xive_native_connect_vcpu(struct kvm_device *dev, > return -EPERM; > if (vcpu->arch.irq_type != KVMPPC_IRQ_DEFAULT) > return -EBUSY; > - if (server_num >= KVM_MAX_VCPUS) { > + if (server_num >= (KVM_MAX_VCPUS * vcpu->kvm->arch.emul_smt_mode)) { > pr_devel("Out of bounds !\n"); > return -EINVAL; > }