From: Bjorn Helgaas Subject: Re: [PATCH v2 4/4] pci: save the boot pcie link speed and restore it on fini Date: Mon, 20 May 2019 16:19:33 -0500 Message-ID: <20190520211933.GA57618@google.com> References: <20190507201245.9295-1-kherbst@redhat.com> <20190507201245.9295-5-kherbst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190507201245.9295-5-kherbst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Karol Herbst Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: nouveau.vger.kernel.org T24gVHVlLCBNYXkgMDcsIDIwMTkgYXQgMTA6MTI6NDVQTSArMDIwMCwgS2Fyb2wgSGVyYnN0IHdy b3RlOgo+IEFwcGVyYW50bHkgdGhpbmdzIGdvIHNvdXRoIGlmIHdlIHN1c3BlbmQgdGhlIGRldmlj ZSB3aXRoIGEgZGlmZmVyZW50IFBDSUUKPiBsaW5rIHNwZWVkIHNldCB0aGFuIGl0IGdvdCBib290 ZWQgd2l0aC4gRml4ZXMgcnVudGltZSBzdXNwZW5kIG9uIG15IGdwMTA3Lgo+IAo+IFRoaXMgYWxs IGxvb2tzIGxpa2Ugc29tZSBidWcgaW5zaWRlIHRoZSBwY2kgc3Vic3lzdGVtIGFuZCBJIHdvdWxk IHByZWZlciBhCj4gZml4IHRoZXJlIGluc3RlYWQgb2Ygbm91dmVhdSwgYnV0IG1heWJlIHRoZXJl IGlzIG5vIHJlYWwgbmljZSB3YXkgb2YgZG9pbmcKPiB0aGF0IG91dHNpZGUgb2YgZHJpdmVycz8K CkkgYWdyZWUgaXQgd291bGQgYmUgbmljZSB0byBmaXggdGhpcyBpbiB0aGUgUENJIGNvcmUgaWYg dGhhdCdzCmZlYXNpYmxlLgoKSXQgbG9va3MgbGlrZSB0aGlzIGRyaXZlciBjaGFuZ2VzIHRoZSBQ Q0llIGxpbmsgc3BlZWQgdXNpbmcgc29tZQpkZXZpY2Utc3BlY2lmaWMgbWVjaGFuaXNtLiAgV2hl biB3ZSBzdXNwZW5kLCB3ZSBwdXQgdGhlIGRldmljZSBpbgpEM2NvbGQsIHNvIGl0IGxvc2VzIGFs bCBpdHMgc3RhdGUuICBXaGVuIHdlIHJlc3VtZSwgdGhlIGxpbmsgcHJvYmFibHkKY29tZXMgdXAg YXQgdGhlIGJvb3Qgc3BlZWQgYmVjYXVzZSBub3RoaW5nIGRpZCB0aGF0IGRldmljZS1zcGVjaWZp YwptYWdpYyB0byBjaGFuZ2UgaXQsIHNvIHlvdSBwcm9iYWJseSBlbmQgdXAgd2l0aCB0aGUgbGlu ayBiZWluZyBzbG93CmJ1dCB0aGUgZHJpdmVyIHRoaW5raW5nIGl0J3MgY29uZmlndXJlZCB0byBi ZSBmYXN0LCBhbmQgbWF5YmUgdGhhdApjb21iaW5hdGlvbiBkb2Vzbid0IHdvcmsuCgpJZiBpdCBy ZXF1aXJlcyBzb21ldGhpbmcgZGV2aWNlLXNwZWNpZmljIHRvIGNoYW5nZSB0aGF0IGxpbmsgc3Bl ZWQsIEkKZG9uJ3Qga25vdyBob3cgdG8gcHV0IHRoYXQgaW4gdGhlIFBDSSBjb3JlLiAgQnV0IG1h eWJlIEknbSBtaXNzaW5nCnNvbWV0aGluZz8KClBlciB0aGUgUENJZSBzcGVjIChyNC4wLCBzZWMg MS4yKToKCiAgSW5pdGlhbGl6YXRpb24g4oCTIER1cmluZyBoYXJkd2FyZSBpbml0aWFsaXphdGlv biwgZWFjaCBQQ0kgRXhwcmVzcwogIExpbmsgaXMgc2V0IHVwIGZvbGxvd2luZyBhIG5lZ290aWF0 aW9uIG9mIExhbmUgd2lkdGhzIGFuZCBmcmVxdWVuY3kKICBvZiBvcGVyYXRpb24gYnkgdGhlIHR3 byBhZ2VudHMgYXQgZWFjaCBlbmQgb2YgdGhlIExpbmsuIE5vIGZpcm13YXJlCiAgb3Igb3BlcmF0 aW5nIHN5c3RlbSBzb2Z0d2FyZSBpcyBpbnZvbHZlZC4KCkkgaGF2ZSBiZWVuIGFzc3VtaW5nIHRo YXQgdGhpcyBtZWFucyBkZXZpY2Utc3BlY2lmaWMgbGluayBzcGVlZAptYW5hZ2VtZW50IGlzIG91 dCBvZiBzcGVjLCBidXQgaXQgc2VlbXMgcHJldHR5IGNvbW1vbiB0aGF0IGRldmljZXMKZG9uJ3Qg Y29tZSB1cCBieSB0aGVtc2VsdmVzIGF0IHRoZSBmYXN0ZXN0IHBvc3NpYmxlIGxpbmsgc3BlZWQu ICBTbwptYXliZSB0aGUgc3BlYyBqdXN0IGludGVuZHMgdGhhdCBkZXZpY2VzIGNhbiBvcGVyYXRl IGF0ICpzb21lKiB2YWxpZApzcGVlZC4KCj4gdjI6IHNxdWFzaGVkIHRvZ2V0aGVyIHBhdGNoIDQg YW5kIDUKPiAKPiBTaWduZWQtb2ZmLWJ5OiBLYXJvbCBIZXJic3QgPGtoZXJic3RAcmVkaGF0LmNv bT4KPiBSZXZpZXdlZC1ieTogTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4KPiAtLS0KPiAg ZHJtL25vdXZlYXUvaW5jbHVkZS9udmttL3N1YmRldi9wY2kuaCB8ICA1ICsrKy0tCj4gIGRybS9u b3V2ZWF1L252a20vc3ViZGV2L3BjaS9iYXNlLmMgICAgfCAgOSArKysrKysrLS0KPiAgZHJtL25v dXZlYXUvbnZrbS9zdWJkZXYvcGNpL3BjaWUuYyAgICB8IDI0ICsrKysrKysrKysrKysrKysrKysr LS0tLQo+ICBkcm0vbm91dmVhdS9udmttL3N1YmRldi9wY2kvcHJpdi5oICAgIHwgIDIgKysKPiAg NCBmaWxlcyBjaGFuZ2VkLCAzMiBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcm0vbm91dmVhdS9pbmNsdWRlL252a20vc3ViZGV2L3BjaS5oIGIvZHJtL25v dXZlYXUvaW5jbHVkZS9udmttL3N1YmRldi9wY2kuaAo+IGluZGV4IDFmZGYzMDk4Li5iMjM3OTNh MiAxMDA2NDQKPiAtLS0gYS9kcm0vbm91dmVhdS9pbmNsdWRlL252a20vc3ViZGV2L3BjaS5oCj4g KysrIGIvZHJtL25vdXZlYXUvaW5jbHVkZS9udmttL3N1YmRldi9wY2kuaAo+IEBAIC0yNiw4ICsy Niw5IEBAIHN0cnVjdCBudmttX3BjaSB7Cj4gIAl9IGFncDsKPiAgCj4gIAlzdHJ1Y3Qgewo+IC0J CWVudW0gbnZrbV9wY2llX3NwZWVkIHNwZWVkOwo+IC0JCXU4IHdpZHRoOwo+ICsJCWVudW0gbnZr bV9wY2llX3NwZWVkIGN1cl9zcGVlZDsKPiArCQllbnVtIG52a21fcGNpZV9zcGVlZCBkZWZfc3Bl ZWQ7Cj4gKwkJdTggY3VyX3dpZHRoOwo+ICAJfSBwY2llOwo+ICAKPiAgCWJvb2wgbXNpOwo+IGRp ZmYgLS1naXQgYS9kcm0vbm91dmVhdS9udmttL3N1YmRldi9wY2kvYmFzZS5jIGIvZHJtL25vdXZl YXUvbnZrbS9zdWJkZXYvcGNpL2Jhc2UuYwo+IGluZGV4IGVlMjQzMWE3Li5kOWZiNWE4MyAxMDA2 NDQKPiAtLS0gYS9kcm0vbm91dmVhdS9udmttL3N1YmRldi9wY2kvYmFzZS5jCj4gKysrIGIvZHJt L25vdXZlYXUvbnZrbS9zdWJkZXYvcGNpL2Jhc2UuYwo+IEBAIC05MCw2ICs5MCw4IEBAIG52a21f cGNpX2Zpbmkoc3RydWN0IG52a21fc3ViZGV2ICpzdWJkZXYsIGJvb2wgc3VzcGVuZCkKPiAgCj4g IAlpZiAocGNpLT5hZ3AuYnJpZGdlKQo+ICAJCW52a21fYWdwX2ZpbmkocGNpKTsKPiArCWVsc2Ug aWYgKHBjaV9pc19wY2llKHBjaS0+cGRldikpCj4gKwkJbnZrbV9wY2llX2ZpbmkocGNpKTsKPiAg Cj4gIAlyZXR1cm4gMDsKPiAgfQo+IEBAIC0xMDAsNiArMTAyLDggQEAgbnZrbV9wY2lfcHJlaW5p dChzdHJ1Y3QgbnZrbV9zdWJkZXYgKnN1YmRldikKPiAgCXN0cnVjdCBudmttX3BjaSAqcGNpID0g bnZrbV9wY2koc3ViZGV2KTsKPiAgCWlmIChwY2ktPmFncC5icmlkZ2UpCj4gIAkJbnZrbV9hZ3Bf cHJlaW5pdChwY2kpOwo+ICsJZWxzZSBpZiAocGNpX2lzX3BjaWUocGNpLT5wZGV2KSkKPiArCQlu dmttX3BjaWVfcHJlaW5pdChwY2kpOwo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gQEAgLTE5Myw4 ICsxOTcsOSBAQCBudmttX3BjaV9uZXdfKGNvbnN0IHN0cnVjdCBudmttX3BjaV9mdW5jICpmdW5j LCBzdHJ1Y3QgbnZrbV9kZXZpY2UgKmRldmljZSwKPiAgCXBjaS0+ZnVuYyA9IGZ1bmM7Cj4gIAlw Y2ktPnBkZXYgPSBkZXZpY2UtPmZ1bmMtPnBjaShkZXZpY2UpLT5wZGV2Owo+ICAJcGNpLT5pcnEg PSAtMTsKPiAtCXBjaS0+cGNpZS5zcGVlZCA9IC0xOwo+IC0JcGNpLT5wY2llLndpZHRoID0gLTE7 Cj4gKwlwY2ktPnBjaWUuY3VyX3NwZWVkID0gLTE7Cj4gKwlwY2ktPnBjaWUuZGVmX3NwZWVkID0g LTE7Cj4gKwlwY2ktPnBjaWUuY3VyX3dpZHRoID0gLTE7Cj4gIAo+ICAJaWYgKGRldmljZS0+dHlw ZSA9PSBOVktNX0RFVklDRV9BR1ApCj4gIAkJbnZrbV9hZ3BfY3RvcihwY2kpOwo+IGRpZmYgLS1n aXQgYS9kcm0vbm91dmVhdS9udmttL3N1YmRldi9wY2kvcGNpZS5jIGIvZHJtL25vdXZlYXUvbnZr bS9zdWJkZXYvcGNpL3BjaWUuYwo+IGluZGV4IDcwY2NiZTBkLi43MzFkZDMwZSAxMDA2NDQKPiAt LS0gYS9kcm0vbm91dmVhdS9udmttL3N1YmRldi9wY2kvcGNpZS5jCj4gKysrIGIvZHJtL25vdXZl YXUvbnZrbS9zdWJkZXYvcGNpL3BjaWUuYwo+IEBAIC04NSw2ICs4NSwxMyBAQCBudmttX3BjaWVf b25laW5pdChzdHJ1Y3QgbnZrbV9wY2kgKnBjaSkKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+ICtp bnQKPiArbnZrbV9wY2llX3ByZWluaXQoc3RydWN0IG52a21fcGNpICpwY2kpCj4gK3sKPiArCXBj aS0+cGNpZS5kZWZfc3BlZWQgPSBudmttX3BjaWVfZ2V0X3NwZWVkKHBjaSk7Cj4gKwlyZXR1cm4g MDsKPiArfQo+ICsKPiAgaW50Cj4gIG52a21fcGNpZV9pbml0KHN0cnVjdCBudmttX3BjaSAqcGNp KQo+ICB7Cj4gQEAgLTEwNSwxMiArMTEyLDIxIEBAIG52a21fcGNpZV9pbml0KHN0cnVjdCBudmtt X3BjaSAqcGNpKQo+ICAJaWYgKHBjaS0+ZnVuYy0+cGNpZS5pbml0KQo+ICAJCXBjaS0+ZnVuYy0+ cGNpZS5pbml0KHBjaSk7Cj4gIAo+IC0JaWYgKHBjaS0+cGNpZS5zcGVlZCAhPSAtMSkKPiAtCQlu dmttX3BjaWVfc2V0X2xpbmsocGNpLCBwY2ktPnBjaWUuc3BlZWQsIHBjaS0+cGNpZS53aWR0aCk7 Cj4gKwlpZiAocGNpLT5wY2llLmN1cl9zcGVlZCAhPSAtMSkKPiArCQludmttX3BjaWVfc2V0X2xp bmsocGNpLCBwY2ktPnBjaWUuY3VyX3NwZWVkLAo+ICsJCQkJICAgcGNpLT5wY2llLmN1cl93aWR0 aCk7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gK2ludAo+ICtudmttX3BjaWVfZmluaShz dHJ1Y3QgbnZrbV9wY2kgKnBjaSkKPiArewo+ICsJaWYgKCFJU19FUlJfVkFMVUUocGNpLT5wY2ll LmRlZl9zcGVlZCkpCj4gKwkJcmV0dXJuIG52a21fcGNpZV9zZXRfbGluayhwY2ksIHBjaS0+cGNp ZS5kZWZfc3BlZWQsIDE2KTsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICBpbnQKPiAgbnZrbV9w Y2llX3NldF9saW5rKHN0cnVjdCBudmttX3BjaSAqcGNpLCBlbnVtIG52a21fcGNpZV9zcGVlZCBz cGVlZCwgdTggd2lkdGgpCj4gIHsKPiBAQCAtMTQ2LDggKzE2Miw4IEBAIG52a21fcGNpZV9zZXRf bGluayhzdHJ1Y3QgbnZrbV9wY2kgKnBjaSwgZW51bSBudmttX3BjaWVfc3BlZWQgc3BlZWQsIHU4 IHdpZHRoKQo+ICAJCXNwZWVkID0gbWF4X3NwZWVkOwo+ICAJfQo+ICAKPiAtCXBjaS0+cGNpZS5z cGVlZCA9IHNwZWVkOwo+IC0JcGNpLT5wY2llLndpZHRoID0gd2lkdGg7Cj4gKwlwY2ktPnBjaWUu Y3VyX3NwZWVkID0gc3BlZWQ7Cj4gKwlwY2ktPnBjaWUuY3VyX3dpZHRoID0gd2lkdGg7Cj4gIAo+ ICAJaWYgKHNwZWVkID09IGN1cl9zcGVlZCkgewo+ICAJCW52a21fZGVidWcoc3ViZGV2LCAicmVx dWVzdGVkIG1hdGNoZXMgY3VycmVudCBzcGVlZFxuIik7Cj4gZGlmZiAtLWdpdCBhL2RybS9ub3V2 ZWF1L252a20vc3ViZGV2L3BjaS9wcml2LmggYi9kcm0vbm91dmVhdS9udmttL3N1YmRldi9wY2kv cHJpdi5oCj4gaW5kZXggYTBkNGMwMDcuLmU3NzQ0NjcxIDEwMDY0NAo+IC0tLSBhL2RybS9ub3V2 ZWF1L252a20vc3ViZGV2L3BjaS9wcml2LmgKPiArKysgYi9kcm0vbm91dmVhdS9udmttL3N1YmRl di9wY2kvcHJpdi5oCj4gQEAgLTYwLDUgKzYwLDcgQEAgZW51bSBudmttX3BjaWVfc3BlZWQgZ2sx MDRfcGNpZV9tYXhfc3BlZWQoc3RydWN0IG52a21fcGNpICopOwo+ICBpbnQgZ2sxMDRfcGNpZV92 ZXJzaW9uX3N1cHBvcnRlZChzdHJ1Y3QgbnZrbV9wY2kgKik7Cj4gIAo+ICBpbnQgbnZrbV9wY2ll X29uZWluaXQoc3RydWN0IG52a21fcGNpICopOwo+ICtpbnQgbnZrbV9wY2llX3ByZWluaXQoc3Ry dWN0IG52a21fcGNpICopOwo+ICBpbnQgbnZrbV9wY2llX2luaXQoc3RydWN0IG52a21fcGNpICop Owo+ICtpbnQgbnZrbV9wY2llX2Zpbmkoc3RydWN0IG52a21fcGNpICopOwo+ICAjZW5kaWYKPiAt LSAKPiAyLjIxLjAKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KTm91dmVhdSBtYWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9ub3V2ZWF1