From: Andy Shevchenko Subject: Re: [PATCH 3/5] i2c: core: Move ACPI IRQ handling to probe time Date: Tue, 21 May 2019 20:18:55 +0300 Message-ID: <20190521171855.GN9224@smile.fi.intel.com> References: <20190521150502.27305-1-ckeepax@opensource.cirrus.com> <20190521150502.27305-4-ckeepax@opensource.cirrus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190521150502.27305-4-ckeepax@opensource.cirrus.com> Sender: linux-kernel-owner@vger.kernel.org To: Charles Keepax Cc: wsa@the-dreams.de, mika.westerberg@linux.intel.com, jarkko.nikula@linux.intel.com, linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, jbroadus@gmail.com, patches@opensource.cirrus.com List-Id: linux-i2c@vger.kernel.org On Tue, May 21, 2019 at 04:05:00PM +0100, Charles Keepax wrote: > Bring the ACPI path in sync with the device tree path and handle all the > IRQ fetching at probe time. This leaves the only IRQ handling at device > registration time being that which is passed directly through the board > info as either a resource or an actual IRQ number. > -static int i2c_acpi_get_irq(struct acpi_device *adev, int *irq) > +int i2c_acpi_get_irq(struct i2c_client *client, int *irq) Instead of ping-pong style of the programming, I would rather do this in the same patch, where you introduce a helper (patch 2 I suppose, after my comments against current patch 2 in the series). Also possible to split exporting itself to a separate patch. -- With Best Regards, Andy Shevchenko