Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0949FC072B5 for ; Tue, 21 May 2019 20:43:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2492217D7 for ; Tue, 21 May 2019 20:43:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2492217D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:59214 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTBc3-0002Ts-Pq for qemu-devel@archiver.kernel.org; Tue, 21 May 2019 16:43:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTBa7-0000uG-V4 for qemu-devel@nongnu.org; Tue, 21 May 2019 16:41:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTBNA-0006nb-Ar for qemu-devel@nongnu.org; Tue, 21 May 2019 16:28:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32892) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTBN9-0006mG-6M; Tue, 21 May 2019 16:28:31 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 785D0307D988; Tue, 21 May 2019 20:28:30 +0000 (UTC) Received: from localhost (ovpn-116-14.gru2.redhat.com [10.97.116.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0803460C18; Tue, 21 May 2019 20:28:27 +0000 (UTC) Date: Tue, 21 May 2019 17:28:26 -0300 From: Eduardo Habkost To: John Snow Message-ID: <20190521202826.GN10764@habkost.net> References: <20190521200657.5377-1-jsnow@redhat.com> <20190521200657.5377-3-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190521200657.5377-3-jsnow@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 21 May 2019 20:28:30 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 2/2] docs/bitmaps: use QMP lexer instead of json X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , qemu-devel@nongnu.org, qemu-block@nongnu.org, Aarushi Mehta Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, May 21, 2019 at 04:06:57PM -0400, John Snow wrote: > The annotated style json we use in QMP documentation is not strict json > and depending on the version of Sphinx (2.0+) or Pygments installed, > might cause the build to fail. > > Use the new QMP lexer. > > Further, some versions of Sphinx can not apply custom lexers to "code" > directives and require the use of "code-block" directives instead, so > make that change at this time as well. > > Tested under: > - Sphinx 1.3.6 and Pygments 2.4 > - Sphinx 1.7.6 and Pygments 2.2 > - Sphinx 2.0.1 and Pygments 2.4 > > Reported-by: Aarushi Mehta > Signed-off-by: John Snow Reviewed-by: Eduardo Habkost -- Eduardo