Received: from list by lists.gnu.org with archive (Exim 4.71) id 1hTiLW-0001bz-8G for mharc-grub-devel@gnu.org; Thu, 23 May 2019 03:41:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTiLU-0001bt-MS for grub-devel@gnu.org; Thu, 23 May 2019 03:41:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTiLT-0001L6-Dh for grub-devel@gnu.org; Thu, 23 May 2019 03:41:00 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:54084) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTiLO-0001Ff-ME for grub-devel@gnu.org; Thu, 23 May 2019 03:40:57 -0400 Received: from mazu (prva10-snat226-1.provo.novell.com [137.65.226.35]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Thu, 23 May 2019 01:40:43 -0600 Date: Thu, 23 May 2019 15:40:28 +0800 From: Michael Chang To: Neil MacLeod Cc: Daniel Kiper , The development of GNU GRUB , John Paul Adrian Glaubitz Subject: Re: [PATCH] f2fs: Fix gcc9 error -Werror=maybe-uninitialized Message-ID: <20190523074028.GB19758@mazu> Mail-Followup-To: Neil MacLeod , Daniel Kiper , The development of GNU GRUB , John Paul Adrian Glaubitz References: <20190517090019.8357-1-mchang@suse.com> <20190517122632.7u5ee25qlcycdxoz@tomti.i.net-space.pl> <20190520114923.rbc4nr57uut4cd3h@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 137.65.250.81 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 May 2019 07:41:01 -0000 On Wed, May 22, 2019 at 05:35:34PM +0100, Neil MacLeod wrote: > > Thanks! I allowed myself to add your Tested-by. I hope this is not a problem for you > > Not at all! > > > This and other fixes posted earlier are now in the tree. > > Latest grub HEAD (53e70d30cf0d18e6c28bab0ab8d223a90d3e1b46) continues > to fail when building f2fs.c with gcc-9.1 due to a packed member issue > - Adrian (John? - sorry!) proposed a fix[1] and Michael confirmed it > is correct, but that fix doesn't yet appear to be in the master tree, > any ideas? > > Thanks > Neil > > 1. http://lists.gnu.org/archive/html/grub-devel/2019-05/msg00096.html Yes, we need the patch from John to solve reported gcc-9 build issue entirely. From the latest update he will do soon. :) http://lists.gnu.org/archive/html/grub-devel/2019-05/msg00099.html Thanks, Michael > > On Mon, 20 May 2019 at 12:49, Daniel Kiper wrote: > > > > On Fri, May 17, 2019 at 05:16:34PM +0100, Neil MacLeod wrote: > > > Hi Daniel & Michael > > > > > > I've tested the new patch (in place of my attempt) and grub is > > > building successfully so it looks good here! > > > > Thanks! I allowed myself to add your Tested-by. I hope this is not > > a problem for you. > > > > Michael, thank you for posting the patch. > > > > This and other fixes posted earlier are now in the tree. > > > > Daniel