From: Imre Deak Subject: Re: [PATCH] drm/i915: Tune down link train error messages due to IO failure Date: Fri, 24 May 2019 22:04:10 +0300 Message-ID: <20190524190410.GA6869@ideak-desk.fi.intel.com> References: <20190523130836.6488-1-imre.deak@intel.com> <5e5ecf1c-3650-56af-0c45-ad8a58ccb59e@linux.intel.com> <20190524164907.GB12657@ideak-desk.fi.intel.com> <20190524183236.GA6124@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id F33A16E0BB for ; Fri, 24 May 2019 19:04:44 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190524183236.GA6124@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Manasi Navare Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXkgMjQsIDIwMTkgYXQgMTE6MzI6MzZBTSAtMDcwMCwgTWFuYXNpIE5hdmFyZSB3 cm90ZToKPiBPbiBGcmksIE1heSAyNCwgMjAxOSBhdCAwNzo0OTowN1BNICswMzAwLCBJbXJlIERl YWsgd3JvdGU6Cj4gPiBPbiBGcmksIE1heSAyNCwgMjAxOSBhdCAwNzoyNzo1NFBNICswMzAwLCBN YXJ0aW4gUGVyZXMgd3JvdGU6Cj4gPiA+IE9uIDIzLzA1LzIwMTkgMTY6MDgsIEltcmUgRGVhayB3 cm90ZToKPiA+ID4gPiBBbiBJTyBmYWlsdXJlIGhhcHBlbnMgaWYgdGhlIHNpbmsgaXMgdW5wbHVn Z2VkLiBUaGlzIHNjZW5hcmlvIHNob3VsZG4ndAo+ID4gPiA+IGJlIGxvZ2dlZCB3aXRoIGVycm9y IGxldmVsLCBzaW5jZSBpdCBpcyBub3QgYSB1c2VyIHZpc2libGUgcHJvYmxlbS4KPiA+ID4gPiBD b252ZXJ0aW5nIHRoZSBjb3JyZXNwb25kaW5nIGVycm9yIG1lc3NhZ2VzIHRvIGJlIGRlYnVnIG1l c3NhZ2VzIGFsc28KPiA+ID4gPiBlbnN1cmVzIHRoYXQgd2UgZG9uJ3QgZmFpbCBzb21lIENJIHRl c3QgaW5jb3JyZWN0bHkgdGhhdCB0ZXN0cyB0aGUKPiA+ID4gPiB1bnBsdWdnaW5nIHdoaWxlIGEg bW9kZSBpcyBzdGlsbCBhY3RpdmUgb24gdGhlIGdpdmVuIGNvbm5lY3RvciAobGlrZSB0aGUKPiA+ ID4gPiBrbXNfY2hhbWVsaXVtIHRlc3RzIGltaXRpdGF0aW5nIHN1Y2ggYW4gdW5wbHVnIGR1cmlu ZyBiZWluZyBzdXNwZW5kZWQpLgo+ID4gPiA+IAo+ID4gPiA+IExlYXZlIHRob3NlIGxpbmsgdHJh aW5pbmcgZXJyb3IgbWVzc2FnZXMgdGhhdCBhcmUgZHVlIHRvIGFuIGFjdHVhbAo+ID4gPiA+IHRy YW5zZmVyIHJhdGUgZXJyb3IgKGFuZCBub3QgYW4gSU8gZXJyb3IpIGFzLWlzLCBhcyB0aGF0IGtp bmQgb2YgcHJvYmxlbQo+ID4gPiA+IGlzIHJlbGF0ZWQgdG8gdGhlIHVzZXIncyBjb25maWd1cmF0 aW9uIChjYWJsZSwgbW9kZSwgbW9uaXRvcikgYW5kIHNvIGl0Cj4gPiA+ID4gaXMgcmVhbGx5IHVz ZXIgdmlzaWJsZS4KPiA+ID4gCj4gPiA+IEFyZSB0aGVyZSBzb21lIHNjZW5hcmlvcyB0aGF0IHdv dWxkIGJlIHdhcnJhbnRpbmcgYSBEUk1fRVJST1I/IElmIHNvLAo+ID4gPiB0aGVuIHdlIHNob3Vs ZCBkZWNpZGUgb24gdGhlIHZlcmJvc2l0eSBiYXNlZCBvbiB3ZXRoZXIgdGhlIGNvbm5lY3RvciBp cwo+ID4gPiBjb25uZWN0ZWQgb3IgZGlzY29ubmVjdGVkLCBkb24ndCB5b3UgdGhpbms/Cj4gPiAK PiA+IEkgZG9uJ3QgdGhpbmsgd2Ugc2hvdWxkIGRlcGVuZCBvbiB0aGUgY29ycmVjdG5lc3Mgb2Yg c2V0dGluZyB0aGUgbWVzc2FnZQo+ID4gbGV2ZWwgY29ycmVjdGx5IGJhc2VkIG9uIHRoZSBsaXZl IHN0YXRlLCBzaW5jZSB0aGUgbGl2ZSBzdGF0ZSBpdHNlbGYgaXMKPiA+IGZsYWt5L3VucmVsaWFi bGUgYmFzZWQgb24gdGhlIHRpbWluZyBvZiB0aGUgdW5wbHVnIHZzLiB0aGUgc2V0dGxpbmcgb2YK PiA+IHRoZSBsaXZlIHN0YXRlIGZsYWcuIEZvciBpbnN0YW5jZSB3ZSBjb3VsZCBzZWUgdGhlIEFV WCBJTyBmYWlsaW5nCj4gPiBhbHJlYWR5IGJ1dCBsaXZlIHN0YXRlIHN0aWxsIGluZGljYXRpbmcg dGhhdCB0aGUgc2luayBpcyBwbHVnZ2VkLCBzbwo+ID4gd2UnZCBwcmludCBhZ2FpbiBhbiBlcnJv ciBpbnN0ZWFkIG9mIHRoZSBjb3JyZWN0IHR1bmVkLWRvd24gbm90ZS4KPiAKPiBCdXQgaW4gY2Fz ZSBvZiBBVVggZmFpbHVyZXMgd2hpY2ggd2Ugc2VlIGEgbG90IHdoZW4gQVVYIHBvd2VyCj4gaXMg YWNjaWRlbnRseSBvZmYgb3IgZURQIGlzIHN0aWxsIG5vdCBPTiBvciBzaW5rIGlzIHVucGx1Z2dl ZCB3aGlsZQo+IHRoZSBsaW5rIHRyYWluaW5nIHdhcyBpbiBwcm9jZXNzLCBkb2VzbnQgaXQgbWFr ZSBzZW5zZSB0bwo+IGNhbGwgaXQgYXMgYSBEUk1fRVJST1IgYW5kIG5vdCBqdXN0IGEgREVCVUdf S01TLgoKTG9nZ2luZyBzdWNoIEFVWCBmYWlscyBhcyBERUJVRyBtYWtlcyBzZW5zZSwgc2luY2Ug aXQgd2lsbCBiZSB1cCB0bwphIGRldmVsb3BlciB0byBsb29rIHRocm91Z2ggdGhlIGxvZ3MgaWYg bmVlZGVkOyBmb3IgaW5zdGFuY2UgaWYgaXQgbGVhZHMKdG8gZmFpbGluZyB0aGUgYWN0dWFsIGxp bmsgdHJhaW5pbmcgbG9nZ2VkIHdpdGggRFJNX0VSUk9SIG9yIGZhaWxpbmcgdGhlCmRldGVjdGlv biB3aGVuIHlvdSBleHBlY3QgdGhlIHNpbmsgdG8gYmUgdGhlcmUuCgpPdG9oLCBpdCdzIGEgYmFk IHRoaW5nIHRvIGxvZyBzdWNoIEFVWCBmYWlscyBhcyBEUk1fRVJST1IgYXMgd2lsbCByZXN1bHQK aW4gZmFpbGluZyB0ZXN0cyBpbmNvcnJlY3RseSB3aGVuIHRoZSBzaW5rIGlzIGRpc2Nvbm5lY3Rl ZCBhbmQgdGhlIEFVWApmYWlscyBoYXBwZW4gYXMgZXhwZWN0ZWQuCgo+IEZvciBFZzogdGhlIENJ IHRlc3RzIGZhaWxlZCBkdWUgdG8gQVVYIHRpbWVvdXRzIHNob3VsZCBiZSB0aGUgYWN0dWFsIGZh aWx1cmVzCj4gd2hpY2ggd291bGQgYmUgZmlsdGVyZWQgbm93IGlmIHdlIHR1bmUgaXQgZG93biB0 byBERUJVR19LTVMuCgpUaGVzZSB3aWxsIGxlYWQgdG8gYWN0dWFsbHkgZmFpbGluZyB0aGUgZGV0 ZWN0aW9uL2xpbmsgdHJhaW5pbmcsIHdoaWNoCnlvdSBjYW4gZGVwZW5kIG9uIGZhaWxpbmcgdGhl IHRlc3RzIGluc3RlYWQgb2YgZGVwZW5kaW5nIG9uIGVycm9yCm1lc3NhZ2VzIGluIGRtZXNnLgoK PiAKPiBNYW5hc2kKPiAgCj4gPiA+IAo+ID4gPiBNYXJ0aW4KPiA+ID4gPiAKPiA+ID4gPiBCdWd6 aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwMzkw Cj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+ ID4gPiA+IC0tLQo+ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9saW5rX3Ry YWluaW5nLmMgfCAxMiArKysrKystLS0tLS0KPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5z ZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiA+ID4gPiAKPiA+ID4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlua190cmFpbmluZy5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlua190cmFpbmluZy5jCj4gPiA+ID4gaW5kZXggOWIxZmNj ZWE5NjZiLi4zOTJlYmViODljZTggMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHBfbGlua190cmFpbmluZy5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHBfbGlua190cmFpbmluZy5jCj4gPiA+ID4gQEAgLTE2OSw3ICsxNjks NyBAQCBpbnRlbF9kcF9saW5rX3RyYWluaW5nX2Nsb2NrX3JlY292ZXJ5KHN0cnVjdCBpbnRlbF9k cCAqaW50ZWxfZHApCj4gPiA+ID4gIAlpZiAoIWludGVsX2RwX3Jlc2V0X2xpbmtfdHJhaW4oaW50 ZWxfZHAsCj4gPiA+ID4gIAkJCQkgICAgICAgRFBfVFJBSU5JTkdfUEFUVEVSTl8xIHwKPiA+ID4g PiAgCQkJCSAgICAgICBEUF9MSU5LX1NDUkFNQkxJTkdfRElTQUJMRSkpIHsKPiA+ID4gPiAtCQlE Uk1fRVJST1IoImZhaWxlZCB0byBlbmFibGUgbGluayB0cmFpbmluZ1xuIik7Cj4gPiA+ID4gKwkJ RFJNX0RFQlVHX0tNUygiZmFpbGVkIHRvIGVuYWJsZSBsaW5rIHRyYWluaW5nXG4iKTsKPiA+ID4g PiAgCQlyZXR1cm4gZmFsc2U7Cj4gPiA+ID4gIAl9Cj4gPiA+ID4gIAo+ID4gPiA+IEBAIC0xOTMs NyArMTkzLDcgQEAgaW50ZWxfZHBfbGlua190cmFpbmluZ19jbG9ja19yZWNvdmVyeShzdHJ1Y3Qg aW50ZWxfZHAgKmludGVsX2RwKQo+ID4gPiA+ICAJCWRybV9kcF9saW5rX3RyYWluX2Nsb2NrX3Jl Y292ZXJ5X2RlbGF5KGludGVsX2RwLT5kcGNkKTsKPiA+ID4gPiAgCj4gPiA+ID4gIAkJaWYgKCFp bnRlbF9kcF9nZXRfbGlua19zdGF0dXMoaW50ZWxfZHAsIGxpbmtfc3RhdHVzKSkgewo+ID4gPiA+ IC0JCQlEUk1fRVJST1IoImZhaWxlZCB0byBnZXQgbGluayBzdGF0dXNcbiIpOwo+ID4gPiA+ICsJ CQlEUk1fREVCVUdfS01TKCJmYWlsZWQgdG8gZ2V0IGxpbmsgc3RhdHVzXG4iKTsKPiA+ID4gPiAg CQkJcmV0dXJuIGZhbHNlOwo+ID4gPiA+ICAJCX0KPiA+ID4gPiAgCj4gPiA+ID4gQEAgLTIxNyw3 ICsyMTcsNyBAQCBpbnRlbF9kcF9saW5rX3RyYWluaW5nX2Nsb2NrX3JlY292ZXJ5KHN0cnVjdCBp bnRlbF9kcCAqaW50ZWxfZHApCj4gPiA+ID4gIAkJLyogVXBkYXRlIHRyYWluaW5nIHNldCBhcyBy ZXF1ZXN0ZWQgYnkgdGFyZ2V0ICovCj4gPiA+ID4gIAkJaW50ZWxfZ2V0X2FkanVzdF90cmFpbihp bnRlbF9kcCwgbGlua19zdGF0dXMpOwo+ID4gPiA+ICAJCWlmICghaW50ZWxfZHBfdXBkYXRlX2xp bmtfdHJhaW4oaW50ZWxfZHApKSB7Cj4gPiA+ID4gLQkJCURSTV9FUlJPUigiZmFpbGVkIHRvIHVw ZGF0ZSBsaW5rIHRyYWluaW5nXG4iKTsKPiA+ID4gPiArCQkJRFJNX0RFQlVHX0tNUygiZmFpbGVk IHRvIHVwZGF0ZSBsaW5rIHRyYWluaW5nXG4iKTsKPiA+ID4gPiAgCQkJcmV0dXJuIGZhbHNlOwo+ ID4gPiA+ICAJCX0KPiA+ID4gPiAgCj4gPiA+ID4gQEAgLTI5NSw3ICsyOTUsNyBAQCBpbnRlbF9k cF9saW5rX3RyYWluaW5nX2NoYW5uZWxfZXF1YWxpemF0aW9uKHN0cnVjdCBpbnRlbF9kcCAqaW50 ZWxfZHApCj4gPiA+ID4gIAkvKiBjaGFubmVsIGVxdWFsaXphdGlvbiAqLwo+ID4gPiA+ICAJaWYg KCFpbnRlbF9kcF9zZXRfbGlua190cmFpbihpbnRlbF9kcCwKPiA+ID4gPiAgCQkJCSAgICAgdHJh aW5pbmdfcGF0dGVybikpIHsKPiA+ID4gPiAtCQlEUk1fRVJST1IoImZhaWxlZCB0byBzdGFydCBj aGFubmVsIGVxdWFsaXphdGlvblxuIik7Cj4gPiA+ID4gKwkJRFJNX0RFQlVHX0tNUygiZmFpbGVk IHRvIHN0YXJ0IGNoYW5uZWwgZXF1YWxpemF0aW9uXG4iKTsKPiA+ID4gPiAgCQlyZXR1cm4gZmFs c2U7Cj4gPiA+ID4gIAl9Cj4gPiA+ID4gIAo+ID4gPiA+IEBAIC0zMDMsNyArMzAzLDcgQEAgaW50 ZWxfZHBfbGlua190cmFpbmluZ19jaGFubmVsX2VxdWFsaXphdGlvbihzdHJ1Y3QgaW50ZWxfZHAg KmludGVsX2RwKQo+ID4gPiA+ICAKPiA+ID4gPiAgCQlkcm1fZHBfbGlua190cmFpbl9jaGFubmVs X2VxX2RlbGF5KGludGVsX2RwLT5kcGNkKTsKPiA+ID4gPiAgCQlpZiAoIWludGVsX2RwX2dldF9s aW5rX3N0YXR1cyhpbnRlbF9kcCwgbGlua19zdGF0dXMpKSB7Cj4gPiA+ID4gLQkJCURSTV9FUlJP UigiZmFpbGVkIHRvIGdldCBsaW5rIHN0YXR1c1xuIik7Cj4gPiA+ID4gKwkJCURSTV9ERUJVR19L TVMoImZhaWxlZCB0byBnZXQgbGluayBzdGF0dXNcbiIpOwo+ID4gPiA+ICAJCQlicmVhazsKPiA+ ID4gPiAgCQl9Cj4gPiA+ID4gIAo+ID4gPiA+IEBAIC0zMjcsNyArMzI3LDcgQEAgaW50ZWxfZHBf bGlua190cmFpbmluZ19jaGFubmVsX2VxdWFsaXphdGlvbihzdHJ1Y3QgaW50ZWxfZHAgKmludGVs X2RwKQo+ID4gPiA+ICAJCS8qIFVwZGF0ZSB0cmFpbmluZyBzZXQgYXMgcmVxdWVzdGVkIGJ5IHRh cmdldCAqLwo+ID4gPiA+ICAJCWludGVsX2dldF9hZGp1c3RfdHJhaW4oaW50ZWxfZHAsIGxpbmtf c3RhdHVzKTsKPiA+ID4gPiAgCQlpZiAoIWludGVsX2RwX3VwZGF0ZV9saW5rX3RyYWluKGludGVs X2RwKSkgewo+ID4gPiA+IC0JCQlEUk1fRVJST1IoImZhaWxlZCB0byB1cGRhdGUgbGluayB0cmFp bmluZ1xuIik7Cj4gPiA+ID4gKwkJCURSTV9ERUJVR19LTVMoImZhaWxlZCB0byB1cGRhdGUgbGlu ayB0cmFpbmluZ1xuIik7Cj4gPiA+ID4gIAkJCWJyZWFrOwo+ID4gPiA+ICAJCX0KPiA+ID4gPiAg CX0KPiA+ID4gPiAKPiA+ID4gCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4