From: Mauro Carvalho Chehab Subject: Re: [PATCH v6 03/16] media: v4l2-common: Support custom imagesize in fill_pixfmt() Date: Wed, 29 May 2019 11:02:33 -0300 Message-ID: <20190529110233.0ff81aff@coco.lan> References: <20190528170232.2091-1-ezequiel@collabora.com> <20190528170232.2091-4-ezequiel@collabora.com> <20190529082809.0b9f3553@coco.lan> <4ef64e22f4035fccf09fbb7f0be04a9778b1230d.camel@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4ef64e22f4035fccf09fbb7f0be04a9778b1230d.camel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Nicolas Dufresne Cc: Heiko Stuebner , Jonas Karlman , Tomasz Figa , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Boris Brezillon , Hans Verkuil , Philipp Zabel , kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, Ezequiel Garcia , linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org RW0gV2VkLCAyOSBNYXkgMjAxOSAwOTo1NDowOSAtMDQwMApOaWNvbGFzIER1ZnJlc25lIDxuaWNv bGFzLmR1ZnJlc25lQGNvbGxhYm9yYS5jb20+IGVzY3JldmV1OgoKPiBIaSBNYXVybywKPiAKPiBM ZSBtZXJjcmVkaSAyOSBtYWkgMjAxOSDDoCAwODoyOCAtMDMwMCwgTWF1cm8gQ2FydmFsaG8gQ2hl aGFiIGEgw6ljcml0IDoKPiA+IEVtIFR1ZSwgMjggTWF5IDIwMTkgMTQ6MDI6MTkgLTAzMDAKPiA+ IEV6ZXF1aWVsIEdhcmNpYSA8ZXplcXVpZWxAY29sbGFib3JhLmNvbT4gZXNjcmV2ZXU6Cj4gPiAK PiA+ID4gRnJvbTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AY29sbGFib3JhLmNv bT4KPiA+ID4gCj4gPiA+IFVzZXJzIGNhbiBkZWZpbmUgY3VzdG9tIHNpemVpbWFnZSBhcyBsb25n IGFzIHRoZXkncmUgYmlnIGVub3VnaCB0bwo+ID4gPiBzdG9yZSB0aGUgYW1vdW50IG9mIHBpeGVs cyByZXF1aXJlZCBmb3IgYSBzcGVjaWZpYyB3aWR0aC9oZWlnaHQgdW5kZXIgYQo+ID4gPiBzcGVj aWZpYyBmb3JtYXQuIEF2b2lkIG92ZXJyaWRpbmcgdGhvc2UgZmllbGRzIGluIHRoaXMgY2FzZS4K PiA+ID4gCj4gPiA+IFdlIGNvdWxkIHBvc3NpYmx5IGRvIHRoZSBzYW1lIGZvciBieXRlc3Blcmxp bmUsIGJ1dCBpdCBnZXRzIHRyaWNreSB3aGVuCj4gPiA+IGRlYWxpbmcgd2l0aCAhTVBMQU5FIGRl ZmluaXRpb25zLCBzbyB0aGlzIGNhc2UgaXMgb21pdHRlZCBmb3Igbm93IGFuZAo+ID4gPiAtPmJ5 dGVzcGVybGluZSBpcyBhbHdheXMgb3ZlcndyaXR0ZW4gd2l0aCB0aGUgdmFsdWUgY2FsY3VsYXRl ZCBpbgo+ID4gPiBmaWxsX3BpeGZtdCgpLgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogQm9y aXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AY29sbGFib3JhLmNvbT4KPiA+ID4gLS0tCj4g PiA+IENoYW5nZXMgZnJvbSB2NToKPiA+ID4gKiBPdmVyd3JpdGUgYnl0ZXNwZXJsaW5lIHdpdGgg dGhlIHZhbHVlIGNhbGN1bGF0ZWQgaW4gZmlsbF9waXhmbXQoKQo+ID4gPiAKPiA+ID4gQ2hhbmdl cyBmcm9tIHY0Ogo+ID4gPiAqIE5ldyBwYXRjaAo+ID4gPiAKPiA+ID4gIGRyaXZlcnMvbWVkaWEv djRsMi1jb3JlL3Y0bDItY29tbW9uLmMgfCA1OCArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0K PiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA0MyBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkK PiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3Y0bDItY29yZS92NGwyLWNv bW1vbi5jIGIvZHJpdmVycy9tZWRpYS92NGwyLWNvcmUvdjRsMi1jb21tb24uYwo+ID4gPiBpbmRl eCBiMmQxZTU1ZDk1NjEuLmZkMjg2ZjZlMTdkNyAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9t ZWRpYS92NGwyLWNvcmUvdjRsMi1jb21tb24uYwo+ID4gPiArKysgYi9kcml2ZXJzL21lZGlhL3Y0 bDItY29yZS92NGwyLWNvbW1vbi5jCj4gPiA+IEBAIC01ODUsOSArNTg1LDkgQEAgaW50IHY0bDJf ZmlsbF9waXhmbXRfbXAoc3RydWN0IHY0bDJfcGl4X2Zvcm1hdF9tcGxhbmUgKnBpeGZtdCwKPiA+ ID4gIAlwaXhmbXQtPm51bV9wbGFuZXMgPSBpbmZvLT5tZW1fcGxhbmVzOwo+ID4gPiAgCj4gPiA+ ICAJaWYgKGluZm8tPm1lbV9wbGFuZXMgPT0gMSkgewo+ID4gPiArCQl1MzIgc2l6ZWltYWdlID0g MDsKPiA+ID4gKwo+ID4gPiAgCQlwbGFuZSA9ICZwaXhmbXQtPnBsYW5lX2ZtdFswXTsKPiA+ID4g LQkJcGxhbmUtPmJ5dGVzcGVybGluZSA9IEFMSUdOKHdpZHRoLCB2NGwyX2Zvcm1hdF9ibG9ja193 aWR0aChpbmZvLCAwKSkgKiBpbmZvLT5icHBbMF07Cj4gPiA+IC0JCXBsYW5lLT5zaXplaW1hZ2Ug PSAwOwo+ID4gPiAgCj4gPiA+ICAJCWZvciAoaSA9IDA7IGkgPCBpbmZvLT5jb21wX3BsYW5lczsg aSsrKSB7Cj4gPiA+ICAJCQl1bnNpZ25lZCBpbnQgaGRpdiA9IChpID09IDApID8gMSA6IGluZm8t PmhkaXY7Cj4gPiA+IEBAIC01OTgsMTAgKzU5OCwyMSBAQCBpbnQgdjRsMl9maWxsX3BpeGZtdF9t cChzdHJ1Y3QgdjRsMl9waXhfZm9ybWF0X21wbGFuZSAqcGl4Zm10LAo+ID4gPiAgCQkJYWxpZ25l ZF93aWR0aCA9IEFMSUdOKHdpZHRoLCB2NGwyX2Zvcm1hdF9ibG9ja193aWR0aChpbmZvLCBpKSk7 Cj4gPiA+ICAJCQlhbGlnbmVkX2hlaWdodCA9IEFMSUdOKGhlaWdodCwgdjRsMl9mb3JtYXRfYmxv Y2tfaGVpZ2h0KGluZm8sIGkpKTsKPiA+ID4gIAo+ID4gPiAtCQkJcGxhbmUtPnNpemVpbWFnZSAr PSBpbmZvLT5icHBbaV0gKgo+ID4gPiAtCQkJCURJVl9ST1VORF9VUChhbGlnbmVkX3dpZHRoLCBo ZGl2KSAqCj4gPiA+IC0JCQkJRElWX1JPVU5EX1VQKGFsaWduZWRfaGVpZ2h0LCB2ZGl2KTsKPiA+ ID4gKwkJCXNpemVpbWFnZSArPSBpbmZvLT5icHBbaV0gKgo+ID4gPiArCQkJCSAgICAgRElWX1JP VU5EX1VQKGFsaWduZWRfd2lkdGgsIGhkaXYpICoKPiA+ID4gKwkJCQkgICAgIERJVl9ST1VORF9V UChhbGlnbmVkX2hlaWdodCwgdmRpdik7Cj4gPiA+ICAJCX0KPiA+ID4gKwo+ID4gPiArCQkvKiBD dXN0b20gYnl0ZXNwZXJsaW5lIHZhbHVlIGlzIG5vdCBzdXBwb3J0ZWQgeWV0LiAqLwo+ID4gPiAr CQlwbGFuZS0+Ynl0ZXNwZXJsaW5lID0gQUxJR04od2lkdGgsCj4gPiA+ICsJCQkJCSAgICB2NGwy X2Zvcm1hdF9ibG9ja193aWR0aChpbmZvLCAwKSkgKgo+ID4gPiArCQkJCSAgICAgIGluZm8tPmJw cFswXTsKPiA+ID4gKwo+ID4gPiArCQkvKgo+ID4gPiArCQkgKiBUaGUgdXNlciBtaWdodCBoYXZl IHNwZWNpZmllZCBhIGN1c3RvbSBzaXplaW1hZ2UsIG9ubHkKPiA+ID4gKwkJICogb3ZlcnJpZGUg aXQgaWYgaXQncyBub3QgYmlnIGVub3VnaC4KPiA+ID4gKwkJICovCj4gPiA+ICsJCXBsYW5lLT5z aXplaW1hZ2UgPSBtYXgoc2l6ZWltYWdlLCBwbGFuZS0+c2l6ZWltYWdlKTsKPiA+IAo+ID4gTm8g dXBwZXIgbGltaXQ/IFRoYXQgZG9lc24ndCBzb3VuZCBhIGdvb2QgaWRlYSB0byBtZSwgc3BlY2lh bGx5IHNpbmNlIHNvbWUKPiA+IChicm9rZW4pIGFwcCBtaWdodCBub3QgYmUgbWVtc2V0IHRoZSBm b3JtYXQgdG8gemVybyBiZWZvcmUgZmlsbGluZyB0aGUgaW9jdGwKPiA+IHN0cnVjdHVyZS4KPiA+ IAo+ID4gUGVyaGFwcyB3ZSBjb3VsZCBkbyBzb21ldGhpbmcgbGlrZToKPiA+IAo+ID4gCQlzaXpl aW1hZ2UgPSBtaW4gKHNpemVpbWFnZSwgMiAqIHBsYW5lLT5zaXplaW1hZ2UpCj4gPiAKPiA+IG9y IHNvbWV0aGluZyBzaW1pbGFyIHRoYXQgd291bGQgYmUgcmVhc29uYWJsZS4KPiA+IAo+ID4gPiAg CX0gZWxzZSB7Cj4gPiA+ICAJCWZvciAoaSA9IDA7IGkgPCBpbmZvLT5jb21wX3BsYW5lczsgaSsr KSB7Cj4gPiA+ICAJCQl1bnNpZ25lZCBpbnQgaGRpdiA9IChpID09IDApID8gMSA6IGluZm8tPmhk aXY7Cj4gPiA+IEBAIC02MTMsMTAgKzYyNCwxOSBAQCBpbnQgdjRsMl9maWxsX3BpeGZtdF9tcChz dHJ1Y3QgdjRsMl9waXhfZm9ybWF0X21wbGFuZSAqcGl4Zm10LAo+ID4gPiAgCQkJYWxpZ25lZF9o ZWlnaHQgPSBBTElHTihoZWlnaHQsIHY0bDJfZm9ybWF0X2Jsb2NrX2hlaWdodChpbmZvLCBpKSk7 Cj4gPiA+ICAKPiA+ID4gIAkJCXBsYW5lID0gJnBpeGZtdC0+cGxhbmVfZm10W2ldOwo+ID4gPiAt CQkJcGxhbmUtPmJ5dGVzcGVybGluZSA9Cj4gPiA+IC0JCQkJaW5mby0+YnBwW2ldICogRElWX1JP VU5EX1VQKGFsaWduZWRfd2lkdGgsIGhkaXYpOwo+ID4gPiAtCQkJcGxhbmUtPnNpemVpbWFnZSA9 Cj4gPiA+IC0JCQkJcGxhbmUtPmJ5dGVzcGVybGluZSAqIERJVl9ST1VORF9VUChhbGlnbmVkX2hl aWdodCwgdmRpdik7Cj4gPiA+ICsKPiA+ID4gKwkJCS8qIEN1c3RvbSBieXRlc3BlcmxpbmUgdmFs dWUgaXMgbm90IHN1cHBvcnRlZCB5ZXQuICovCj4gPiAKPiA+IFN1cHBvcnRpbmcgY3VzdG9tIGJ5 dGVzcGVybGluZSBzZWVtcyB0b28gcmlza3kgb2YgYnJlYWtpbmcgYXBwcy4gCj4gPiBTbywgSSB3 b3VsZCBkcm9wIHRoaXMgY29tbWVudC4KPiAKPiBXZSB3aWxsIHJlYWxseSBuZWVkIHRoaXMgaW4g dGhlIGxvbmcgcnVuIGluIG1hbnkgZHJpdmVycyBpbiBvcmRlciB0bwo+IGFsbG93IGltcG9ydC9l eHBvcnQgb2YgRE1BQnVmLiBXaXRob3V0IHN1Y2ggYWRhcHRpdmUgZmVhdHVyZSwgd2UgaGF2ZSBh Cj4gc29mdHdhcmUgbGltaXRhdGlvbiB0aGF0IGZvcmNlcyBib3VuY2luZyBtZW1vcnkuIEkgaGF2 ZSBhbHJlYWR5Cj4gZGlzY3Vzc2VkIGFib3V0IGFkZGluZyB0aGlzIGZlYXR1cmUgbm90YWJseSBp biB2aXZpZCBhbmQgdXZjdmlkZW8gb24KPiBJUkMgYW5kIGluIGNvbmZlcmVuY2UsIHdoaWNoIGJv dGggaGF2ZSBubyByZXN0cmljdGlvbiB0aGUgbWVtb3J5Cj4gYWxpZ25tZW50LCBzbyBzaG91bGQg YWxsb3cgaW1wb3J0aW5nIGFueSBraW5kIG9mIHZpZGVvIGxheW91dC4KPiAKPiBXZSBhbHJlYWR5 IGhhdmUgYSBwYXJ0aWFsIHVzZXJzcGFjZSBpbXBsZW1lbnRhdGlvbiBmb3IgdGhpcyBpbgo+IEdT dHJlYW1lciBhbmQgdXBzdHJlYW0gZHJpdmVyIHN1Ym1pc3Npb24gc2hvdWxkIGNvbWUgd2hlbiB0 aGUgSVAgaXMKPiBjb25zaWRlcmVkIHN0YWJsZSBlbm91Z2guCgpJIHVuZGVyc3RhbmQgdGhlIG5l ZWQuIEknbSBub3QgYWdhaW5zdCBhbiBpbXBsZW1lbnRhdGlvbiBmb3Igc3VjaApmZWF0dXJlLCBw cm92aWRlZCB0aGF0IGl0IHdvbid0IGJyZWFrIGFueXRoaW5nLgoKSSBndWVzcyBvbmUgb2YgdGhl IHRoaW5ncyB3ZSBtaXNzIGF0IFY0TDIgQVBJIGlzIGFuIGluZGljYXRpb24gZnJvbQp1c2Vyc3Bh Y2UgYWJvdXQgd2hhdCBpdCBzdXBwb3J0cy4gSSBtZWFuLCBqdXN0IGxpa2Ugd2UgaGF2ZSB0aGUK Y2FwcyBmbGFncyB3aGVyZSB0aGUgS2VybmVsIHJlcG9ydHMgd2hhdCBpdCBzdXBwb3J0cywgd2Ug Y291bGQgaGF2ZQphIHNpbWlsYXIgInVzZXJzcGFjZSBjYXBzIiAgZmllbGQuCgo+IFdoeSBJIHRo aW5rIGl0IHdvbid0IGJyZWFrIHVzZXJzcGFjZSBpcyB0aGF0IHRoZSBjb3JyZWN0IHdheSB0byB1 c2UKPiB0aGVzZSByZWFkLW9ubHkgbWVtYmVycyBvZiBWNEwyIHN0cnVjdCBpcyB0byBzZXQgdGhl c2UgdG8gMCwgd2hpY2ggaXMKPiBhbHNvIGRvY3VtZW50ZWQuCgpZZWFoLCB0aGUgYXBwcyBJJ20g YXdhcmUgb2YgdXN1YWxseSBjYWxsIG1lbXNldCgpIGJlZm9yZSBmaWxsaW5nClY0TDIgc3RydWN0 cy4gT24gdGhvc2UsIGFkZGluZyB0aGlzIGJlaGF2aW9yIHdvdWxkIGJlIG9rLiBZZXQsCkknbSBu b3Qgc3VyZSBpZiAxMDAlIG9mIChvcGVuIHNvdXJjZSkgYXBwcyBkbyB0aGF0LgoKPiBBZGRpbmcg dXBwZXIgYm91bmQgc2VlbXMgbGlrZSBhIGdvb2QgaWRlYSB0aG91Z2guCgpBZ3JlZWQuCgo+IAo+ ClRoYW5rcywKTWF1cm8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtcm9ja2NoaXAK