Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80F1FC04AB5 for ; Mon, 3 Jun 2019 13:06:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 562F827FD9 for ; Mon, 3 Jun 2019 13:06:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Y8qgTAkt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728070AbfFCNG6 (ORCPT ); Mon, 3 Jun 2019 09:06:58 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50292 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726343AbfFCNG5 (ORCPT ); Mon, 3 Jun 2019 09:06:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Fypb0A6OA46EoyKfK6f76wA+kx+ipWKp3Lwp1Yf8N04=; b=Y8qgTAkt1xsqb6Yi9BDBfBTrCI edtdDLNgff7T/Qk4vB6NDxvPcZWm138KLF2z4n3GZarRX5M+dA/6gXBrdqu5FBh4quOo+bz023HKc LR5leZidv6qKXKJNjd7fAH9HIkwI4kgx7y/eAFz321geiTGycl916L+8W6AFHpOQAtfE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hXmfu-0004wr-9Y; Mon, 03 Jun 2019 15:06:54 +0200 Date: Mon, 3 Jun 2019 15:06:54 +0200 From: Andrew Lunn To: Vladimir Oltean Cc: Florian Fainelli , Vivien Didelot , "David S. Miller" , netdev Subject: Re: [PATCH v2 net 1/1] net: dsa: sja1105: Fix link speed not working at 100 Mbps and below Message-ID: <20190603130654.GF17267@lunn.ch> References: <20190602233137.17930-1-olteanv@gmail.com> <20190602233137.17930-2-olteanv@gmail.com> <20190603005053.GH19081@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Hi Andrew, > > If I made the change you're suggesting, I would need to replace 0 with > SPEED_UNKNOWN and thus I would conflict with this net-next change: > > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=af7cd0366ee994e8b35985d407261dc0ed9dfb4d > > I think it's simpler to wait until Dave merges net into net-next and > then submit this 1000 -> SPEED_1000 change as a net-next one, and let > the fix itself go into net. > Sounds ok? Fine. Andrew