Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B8BBC04AB5 for ; Mon, 3 Jun 2019 19:52:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3346226AFD for ; Mon, 3 Jun 2019 19:52:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="W4+FGBY/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726157AbfFCTwy (ORCPT ); Mon, 3 Jun 2019 15:52:54 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:52102 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726097AbfFCTwy (ORCPT ); Mon, 3 Jun 2019 15:52:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RsUg87dAobfAiplMu0/0jwwgrBPCdJebNZeo5hRL40k=; b=W4+FGBY/S7rki270opj8y+RsWG 7xertR3XOA6oMReh5Gv4m0FVQYHi7cFNZpW4Vs5rw+H+MGmNIcyPMHDcGXvXhQBvNyCwq98mZ6xYd EQ3DBClccK3eY+WzgjMq6mZ9P/X4E9rMqJj6Q/a6dfIYmYitPnLP+fIIb56tXt4nyCcE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hXt0h-0007ie-Ax; Mon, 03 Jun 2019 21:52:47 +0200 Date: Mon, 3 Jun 2019 21:52:47 +0200 From: Andrew Lunn To: Russell King Cc: "David S. Miller" , Florian Fainelli , Heiner Kallweit , netdev@vger.kernel.org Subject: Re: [PATCH] net: sfp: read eeprom in maximum 16 byte increments Message-ID: <20190603195247.GM19627@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Jun 02, 2019 at 03:13:00PM +0100, Russell King wrote: > Some SFP modules do not like reads longer than 16 bytes, so read the > EEPROM in chunks of 16 bytes at a time. This behaviour is not specified > in the SFP MSAs, which specifies: > > "The serial interface uses the 2-wire serial CMOS E2PROM protocol > defined for the ATMEL AT24C01A/02/04 family of components." > > and > > "As long as the SFP+ receives an acknowledge, it shall serially clock > out sequential data words. The sequence is terminated when the host > responds with a NACK and a STOP instead of an acknowledge." > > We must avoid breaking a read across a 16-bit quantity in the diagnostic > page, thankfully all 16-bit quantities in that page are naturally > aligned. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew