From: Michal Hocko Subject: Re: [RFCv2 1/6] mm: introduce MADV_COLD Date: Tue, 4 Jun 2019 09:02:28 +0200 Message-ID: <20190604070228.GD4669@dhcp22.suse.cz> References: <20190531064313.193437-1-minchan@kernel.org> <20190531064313.193437-2-minchan@kernel.org> <20190531084752.GI6896@dhcp22.suse.cz> <20190531133904.GC195463@google.com> <20190531140332.GT6896@dhcp22.suse.cz> <20190531143407.GB216592@google.com> <20190603071607.GB4531@dhcp22.suse.cz> <20190604042651.GC43390@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190604042651.GC43390@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , linux-api@vger.kernel.org, Johannes Weiner , Tim Murray , Joel Fernandes , Suren Baghdasaryan , Daniel Colascione , Shakeel Butt , Sonny Rao , Brian Geffon , jannh@google.com, oleg@redhat.com, christian@brauner.io, oleksandr@redhat.com, hdanton@sina.com List-Id: linux-api@vger.kernel.org On Tue 04-06-19 13:26:51, Minchan Kim wrote: > On Mon, Jun 03, 2019 at 09:16:07AM +0200, Michal Hocko wrote: [...] > > Right. But there is still the page cache reclaim. Is it expected that > > an explicitly cold memory doesn't get reclaimed because we have a > > sufficient amount of page cache (a very common case) and we never age > > anonymous memory because of that? > > If there are lots of used-once pages in file-LRU, I think there is no > need to reclaim anonymous pages because it needs bigger overhead due to > IO. It has been true for a long time in current VM policy. You are making an assumption which is not universally true. If I _know_ that there is a considerable amount of idle anonymous memory then I would really prefer if it goes to the swap rather than make a pressure on caching. Inactive list is not guaranteed to contain only used-once pages, right? Anyway, as already mentioned, we can start with a simpler implementation for now and explicitly note that pagecache biased reclaim is known to be a problem potentially. I am pretty sure somebody will come sooner or later and we can address the problem then with some good numbers to back the additional complexity. -- Michal Hocko SUSE Labs