Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F9CBC28CC5 for ; Wed, 5 Jun 2019 13:35:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8A4B206BB for ; Wed, 5 Jun 2019 13:35:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8A4B206BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:41839 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYW4b-0001M9-Pv for qemu-devel@archiver.kernel.org; Wed, 05 Jun 2019 09:35:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYW3G-0000jn-O0 for qemu-devel@nongnu.org; Wed, 05 Jun 2019 09:34:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYW3F-0002Y4-UY for qemu-devel@nongnu.org; Wed, 05 Jun 2019 09:34:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59892) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYW3F-0002X6-PV for qemu-devel@nongnu.org; Wed, 05 Jun 2019 09:34:01 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 97169A3B5E for ; Wed, 5 Jun 2019 13:34:00 +0000 (UTC) Received: from localhost (ovpn-116-9.gru2.redhat.com [10.97.116.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2724860579; Wed, 5 Jun 2019 13:33:57 +0000 (UTC) Date: Wed, 5 Jun 2019 10:33:56 -0300 From: Eduardo Habkost To: Wainer dos Santos Moschetta Message-ID: <20190605133356.GM22416@habkost.net> References: <20190531165334.20403-1-wainersm@redhat.com> <20190531165334.20403-2-wainersm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190531165334.20403-2-wainersm@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 05 Jun 2019 13:34:00 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 1/1] accel: Remove unused AccelClass::opt_name attribute X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, May 31, 2019 at 12:53:34PM -0400, Wainer dos Santos Moschetta wrote: > The AccelType type was converted to AccelClass QOM > object on b14a0b7469f, and the original data type had > a field to store the option name which in turn was > used to search an accelerator. The lookup method > (accel_find) changed too, making the option field > unnecessary but it became AccelClass::opt_name despite > that. Therefore, and given that none accelerator > implementation sets AccelClass::opt_name, let's > remove this attribute. > > Signed-off-by: Wainer dos Santos Moschetta Queued, thanks! -- Eduardo