From: hch@lst.de (Christoph Hellwig) Date: Fri, 7 Jun 2019 18:42:41 +0200 Subject: [PATCH 2/2] nvme: Set physical block size and optimal I/O size according to NVMe 1.4 In-Reply-To: <969c0a9c-2e5a-b609-5c3b-411f9f2bf6ca@acm.org> References: <20190606212854.122478-1-bvanassche@acm.org> <20190606212854.122478-3-bvanassche@acm.org> <969c0a9c-2e5a-b609-5c3b-411f9f2bf6ca@acm.org> Message-ID: <20190607164241.GB7307@lst.de> On Thu, Jun 06, 2019@02:48:24PM -0700, Bart Van Assche wrote: > On 6/6/19 2:42 PM, Chaitanya Kulkarni wrote: >> Looks good. One quick question though do you actually have a controller >> on which you have tested this feature ? > > Hi Chaitanya, > > From the cover letter of this patch series: "These patches > compile correctly but have not been tested in any other way." You could create something based of our linux I/O limits for the Linux nvme target to expose those and test the code.