From: Christoph Hellwig Subject: Re: [PATCH 10/13] megaraid_sas: set virt_boundary_mask in the scsi host Date: Sat, 8 Jun 2019 10:14:00 +0200 Message-ID: <20190608081400.GA19573@lst.de> References: <20190605190836.32354-1-hch@lst.de> <20190605190836.32354-11-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Kashyap Desai Cc: Christoph Hellwig , Jens Axboe , Sebastian Ott , Sagi Grimberg , Max Gurtovoy , Bart Van Assche , Ulf Hansson , Alan Stern , Oliver Neukum , linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mmc@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, "PDL,MEGARAIDLINUX" , PDL-MPT-FUSIONLINUX , linux-hyperv@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org List-Id: linux-mmc@vger.kernel.org On Thu, Jun 06, 2019 at 09:07:27PM +0530, Kashyap Desai wrote: > Hi Christoph, Changes for and looks good. We want > to confirm few sanity before ACK. BTW, what benefit we will see moving > virt_boundry setting to SCSI mid layer ? Is it just modular approach OR any > functional fix ? The big difference is that virt_boundary now also changes the max_segment_size, and this ensures that this limit is also communicated to the DMA mapping layer.