From: ming.lei@redhat.com (Ming Lei) Date: Mon, 10 Jun 2019 10:41:28 +0800 Subject: [PATCH 2/3] nvme-pci: remove queue_count_ops for write,poll_queues In-Reply-To: <20190610022522epcms2p26bc1b339680476ac6d81050045545f44@epcms2p2> References: <20190610015155.GD26551@ming.t460p> <20190608180219.17523-1-minwoo.im.dev@gmail.com> <20190608180219.17523-3-minwoo.im.dev@gmail.com> <20190610022522epcms2p26bc1b339680476ac6d81050045545f44@epcms2p2> Message-ID: <20190610024127.GE26551@ming.t460p> On Mon, Jun 10, 2019@11:25:22AM +0900, Minwoo Im wrote: > > However, the check is valid, which shouldn't be nop, so could you fix > > the check instead of removing it? > > Hi, Ming. > > I don't get what you really mean here. What do you mean "the check is > valid"? I don't see any valid checks in queue_count_set(), not just for > check for the failure by kstrtoint(). I think current code is just checks > the nr_cpus and do nothing after. > > Instead fixing this check inside of this function, I have posted the next > patch in this series to make sure the number of irqs requested not > exceed the num_possible_num(). I suggest to cap 'write_queues' or 'poll_writes' to num_possible_num() from the beginning, instead of starting with invalid number. thanks, Ming