Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05634C5ACC3 for ; Mon, 10 Jun 2019 14:17:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A8F83207E0 for ; Mon, 10 Jun 2019 14:17:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="hLyPgrWN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8F83207E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3C05B6B026C; Mon, 10 Jun 2019 10:17:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 371136B026D; Mon, 10 Jun 2019 10:17:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23A426B026E; Mon, 10 Jun 2019 10:17:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by kanga.kvack.org (Postfix) with ESMTP id C62056B026C for ; Mon, 10 Jun 2019 10:17:29 -0400 (EDT) Received: by mail-ed1-f72.google.com with SMTP id s5so15597696eda.10 for ; Mon, 10 Jun 2019 07:17:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:thread-topic :thread-index:date:message-id:references:in-reply-to:accept-language :content-language:content-id:content-transfer-encoding:mime-version; bh=7VKPV0tzhnrabZGKNCz1su4wa9sEz27AcIfx17kUjTY=; b=P1ETppX0UeaaLpapGm/SX0EsONHlWA6MWM4j97Wb9X4NATrllPJGNzehp87H1OXvyU Dh6GWGUSz34cdQhORLn1RPsJ0SkYkJYxLUyPJJwRV3feKkA2VbrPcRvUstaKVBv3emNa ksBsyKjyJCn7ThC77b8BVwUAxydQcyvKewQkoxik0uCX+25d55HDwdcbjqY8Mr8WUsXk SMY/8F2a05kUpbTRWW0Cy69vd8bON6zek3BYgDEFPbA5dMmwGmAvktDl24OXUiwhuMvC 08BLsTgaVc/yhMdE/6Z4QAkaSJ26NkOnh5BLgnpkNwXT2D9WCAzUZGsz5VcJCIzg+7eO HO3Q== X-Gm-Message-State: APjAAAUM2JnuVpt8kyzViUsKPkFHBSSXsAbNPT4TG3QHFlE5Y+BmojiO QhpB57Z9gfexT7loLdXqBTFX0MKdBfVdvcRF3r8rGH95+5cBuLzDP2VZvvrdT+Gzu3M56TK7lZZ HB0EAFhmRlo8sbFP+DO389S67c/nlF2xgQxiacTVWDfCM+OQx5QhzFcOhKcEl1HZDZQ== X-Received: by 2002:a17:906:9a9:: with SMTP id q9mr59620959eje.125.1560176249349; Mon, 10 Jun 2019 07:17:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqzKMjYI1rRLQ3tK8ZMHcONsY+RbncFgVvkvvRX9+sPy8S4N1dl7NfqZmKjum4mDmDbve5Vi X-Received: by 2002:a17:906:9a9:: with SMTP id q9mr59620908eje.125.1560176248637; Mon, 10 Jun 2019 07:17:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560176248; cv=none; d=google.com; s=arc-20160816; b=Iawz8pDkfWljaeqCokAXg1PSdKXevXQSdZ5S3vVk1s4j3aJDl+iRLFF1aSy+TVQATP 1b8vsZ3ATeZRQFTefHnqJKRlJx9sOI7WkweoOEMCdEek8ErwYShA16RWrYt2uXBrN/3H 04qBzi/WLmoeVibyD11dIlDN8FX8/Ocspm98vSxOe4QwJu8o64hxSAxMPFARg0qhoPAW m0PQMhkcqJvmtF7M5CqtBWVfgrVhGdCkqKXYGAk8/MR7h1pXox8cplVQCrDjBPJnPcVg enCLn+zp5OjHb8ztcbbHfPKORrNhmmONwIEt1CKhoZbPba6F4NbnwdLjZDO2hlCv7LFz n18w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:content-id:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature; bh=7VKPV0tzhnrabZGKNCz1su4wa9sEz27AcIfx17kUjTY=; b=kRndhLSKM03fuA7qMxc0SvYiZz6YjYyodoJuObUQoKwLNvvnNfoYix18lxWaqwZOG+ zCRwd6m932V71gLHIsf7AYAf57qbO4fSqMYs1vv9aI8/i17uY20y7Vz+Z62N+OlUQ9Ii GRKzEqwxbnDB6a00wKC1LWSMkscBEnDwsRjdbu6I6Rc5tBb1JX+V7R1FUXOQM7g/ekW9 n8LMpTOTEoiS0FROAr06N5EZtz3V7CYaM96caORuQ9JtzDJW8y4CEIkn64Y2jO4M/VJe 20ku6dyZ/tspoL/fKSaRPku1jbyjbs/Q9naZ3uX9M9IeVUyOUihQg/D+XNWfDWiWR8T6 N5JA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector2 header.b=hLyPgrWN; spf=pass (google.com: domain of jgg@mellanox.com designates 40.107.1.63 as permitted sender) smtp.mailfrom=jgg@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10063.outbound.protection.outlook.com. [40.107.1.63]) by mx.google.com with ESMTPS id x31si1230226edx.312.2019.06.10.07.17.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Jun 2019 07:17:28 -0700 (PDT) Received-SPF: pass (google.com: domain of jgg@mellanox.com designates 40.107.1.63 as permitted sender) client-ip=40.107.1.63; Authentication-Results: mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector2 header.b=hLyPgrWN; spf=pass (google.com: domain of jgg@mellanox.com designates 40.107.1.63 as permitted sender) smtp.mailfrom=jgg@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7VKPV0tzhnrabZGKNCz1su4wa9sEz27AcIfx17kUjTY=; b=hLyPgrWNr+SEdM7P7UWUBP1RwT+zGT4xIuA6yQr8FZua36SL6oQAh0oBIIEet7L5lnAakOwz6yffdkS66vqYx9dCqGYsAs9H/7wkB07H3QXpPYEjSnvdLgtQNsQ/e6S9Yb8L9vpL99JTPX6SnfmTuaZuezwutQI4fnsFyzTMemk= Received: from VI1PR05MB4141.eurprd05.prod.outlook.com (10.171.182.144) by VI1PR05MB5245.eurprd05.prod.outlook.com (20.178.10.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.12; Mon, 10 Jun 2019 14:17:25 +0000 Received: from VI1PR05MB4141.eurprd05.prod.outlook.com ([fe80::c16d:129:4a40:9ba1]) by VI1PR05MB4141.eurprd05.prod.outlook.com ([fe80::c16d:129:4a40:9ba1%6]) with mapi id 15.20.1965.017; Mon, 10 Jun 2019 14:17:25 +0000 From: Jason Gunthorpe To: Michal Hocko CC: Stable tree , Greg KH , "linux-mm@kvack.org" , LKML , Andrea Arcangeli , Jann Horn , Oleg Nesterov , Peter Xu , Mike Rapoport , Andrew Morton , Linus Torvalds , Joel Fernandes Subject: Re: [PATCH stable 4.4 v2] coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping Thread-Topic: [PATCH stable 4.4 v2] coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping Thread-Index: AQHVH2CnxFwP6PSr9UaRiZwKrYERwKaU6mGAgAAFSwA= Date: Mon, 10 Jun 2019 14:17:25 +0000 Message-ID: <20190610141720.GB18446@mellanox.com> References: <20190604094953.26688-1-mhocko@kernel.org> <20190610074635.2319-1-mhocko@kernel.org> <20190610135823.GI30967@dhcp22.suse.cz> In-Reply-To: <20190610135823.GI30967@dhcp22.suse.cz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: YQXPR0101CA0034.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:15::47) To VI1PR05MB4141.eurprd05.prod.outlook.com (2603:10a6:803:4d::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jgg@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [156.34.55.100] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c06878eb-7dee-45e3-cba7-08d6edae5cb9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR05MB5245; x-ms-traffictypediagnostic: VI1PR05MB5245: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 0064B3273C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(366004)(136003)(396003)(376002)(39860400002)(199004)(189003)(52116002)(66476007)(66556008)(64756008)(66446008)(66066001)(73956011)(66946007)(36756003)(6512007)(446003)(71200400001)(53936002)(71190400001)(6486002)(1076003)(486006)(186003)(2616005)(229853002)(476003)(6506007)(102836004)(26005)(76176011)(6436002)(386003)(11346002)(99286004)(305945005)(81166006)(86362001)(4326008)(81156014)(25786009)(14454004)(7736002)(478600001)(68736007)(8676002)(8936002)(54906003)(6916009)(6246003)(7416002)(14444005)(256004)(316002)(5660300002)(2906002)(6116002)(3846002)(33656002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB5245;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 5Na//MXe9sjEuP/oAreM90Sxf3FbqOSXVchIZVJxjBSVTlnYlzmCyyQGCSkEmawoRtZCgra4CzlN5vllOSRxHmF1gURfsiTtyU2HpYoCF7wFiwfsmw65MW08VPB/RDAO/V/St4fRfcpudsWK3A9Q6BGEJpwbRu6n+yOHf8CUcZCxBX9LIpFXWEOMcjpvQNS5AV3fz//VvKv+D/fnm6NozIXsT5vfE2k/AZy3RMnJR4APMMfynppHz/TCQvoQFm+eup5dh8E/ucljoQt/zQ2noso5yMISsnmGAnQls1Cei2tBOSe2/+cT68BJjbADRd0JamzT1ObnGSko1mRkY8Wq1A9eCZqs2Z89FIqYmJveA3KcEQd0ibRpRBB1s2TCS4/uN62eCFgLJ9gnbV1+3POG053vh/ZiQwHlnDb1pNCLQ48= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c06878eb-7dee-45e3-cba7-08d6edae5cb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2019 14:17:25.7844 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jgg@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5245 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 10, 2019 at 03:58:23PM +0200, Michal Hocko wrote: > Just a heads up. Ajay Kaher has noticed that mlx4 driver is missing the > check in 4.14 [1] and 4.4 seems to have the same problem. I will wait > for more review before reposting v3. The incremental diff is: >=20 > diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/ml= x4/main.c > index 67c4c73343d4..6968154a073e 100644 > +++ b/drivers/infiniband/hw/mlx4/main.c > @@ -1042,6 +1042,8 @@ static void mlx4_ib_disassociate_ucontext(struct ib= _ucontext *ibcontext) > * mlx4_ib_vma_close(). > */ > down_write(&owning_mm->mmap_sem); > + if (!mmget_still_valid(owning_mm)) > + goto skip_mm; > for (i =3D 0; i < HW_BAR_COUNT; i++) { > vma =3D context->hw_bar_info[i].vma; > if (!vma) > @@ -1061,6 +1063,7 @@ static void mlx4_ib_disassociate_ucontext(struct ib= _ucontext *ibcontext) > context->hw_bar_info[i].vma->vm_ops =3D NULL; > } > =20 > +skip_mm: > up_write(&owning_mm->mmap_sem); > mmput(owning_mm); > put_task_struct(owning_process); Looks OK to me Jason