Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95EC3C4321A for ; Tue, 11 Jun 2019 13:51:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B52420896 for ; Tue, 11 Jun 2019 13:51:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dk69qGdM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B52420896 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3ymWVwDo+X4/YyOxOtbza/EQnGS1pOw2xHYwZ0kiwqk=; b=dk69qGdMMhSo7Q PypRODGbbRMTIE9ogL96un0m36epsZTa6zc1Ruxl1CyJFBVqRURDl9D71h9R7JeYIW9vSpagL0HHb cl4nHwoxTEyHE+JlsmO7h7ZE8Cuno2lnylXTSksP3LKP6BxDifjlbvrYwv9w4ECuvjvBzAMpfZAMH zLr0dDLD+fPQeZdBvYP+qphC0s5hWHKL/HAwZODX1q7DznNAr77MD7EhG7n8r5S7czHfY2w4yaLp5 tLCINtN+auBvj2K+jGDKlGFif2SnMERo/Wr8qQH/hhZBo63UN4AE39DcVbxRYnNJP2HImUedtzdaz ojegVYhREAVqncAfMFmg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hahAz-0003DP-I0; Tue, 11 Jun 2019 13:51:01 +0000 Received: from verein.lst.de ([213.95.11.211] helo=newverein.lst.de) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hahAw-0003Cy-Do for linux-riscv@lists.infradead.org; Tue, 11 Jun 2019 13:50:59 +0000 Received: by newverein.lst.de (Postfix, from userid 2407) id 3148468AA6; Tue, 11 Jun 2019 15:50:31 +0200 (CEST) Date: Tue, 11 Jun 2019 15:50:30 +0200 From: Christoph Hellwig To: Andreas Schwab Subject: Re: [PATCH] riscv: export pm_power_off again Message-ID: <20190611135030.GB28532@lst.de> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190611_065058_614644_F77DEDC4 X-CRM114-Status: UNSURE ( 6.33 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Atish Patra , linux-riscv@lists.infradead.org, Palmer Dabbelt , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Jun 11, 2019 at 12:28:40PM +0200, Andreas Schwab wrote: > Commit bf0102a0fdd9 ("riscv: call pm_power_off from machine_halt / > machine_power_off") removed the export of pm_power_off, but it is used by > several modules: > > ERROR: "pm_power_off" [drivers/mfd/rk808.ko] undefined! > ERROR: "pm_power_off" [drivers/mfd/max8907.ko] undefined! > ERROR: "pm_power_off" [drivers/mfd/axp20x.ko] undefined! > ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined! > > Signed-off-by: Andreas Schwab None of these drivers should be buildable on RISC-V. Please work with the maintainers to fix this up. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv