From: Mika Westerberg Subject: Re: [PATCH 3/3 v6] tty/serial/8250: use mctrl_gpio helpers Date: Thu, 13 Jun 2019 21:34:05 +0300 Message-ID: <20190613183405.GT2640@lahna.fi.intel.com> References: <20190613154542.32438-1-sr@denx.de> <20190613154542.32438-3-sr@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190613154542.32438-3-sr@denx.de> Sender: linux-kernel-owner@vger.kernel.org To: Stefan Roese Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Yegor Yefremov , Andy Shevchenko , Giulio Benetti , Greg Kroah-Hartman List-Id: linux-serial@vger.kernel.org On Thu, Jun 13, 2019 at 05:45:42PM +0200, Stefan Roese wrote: > From: Yegor Yefremov > > This patch permits the usage for GPIOs to control > the CTS/RTS/DTR/DSR/DCD/RI signals. > > Changed by Stefan: > Only call mctrl_gpio_init(), if the device has no ACPI companion device > to not break existing ACPI based systems. Also only use the mctrl_gpio_ > functions when "gpios" is available. > > Use MSR / MCR <-> TIOCM wrapper functions. > > Signed-off-by: Yegor Yefremov > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Stefan Roese > Cc: Mika Westerberg Reviewed-by: Mika Westerberg