From: Daniel Vetter Subject: Re: [PATCH v2 07/12] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing Date: Tue, 18 Jun 2019 16:16:04 +0200 Message-ID: <20190618141604.GC12905@phenom.ffwll.local> References: <20190618135821.8644-1-kraxel@redhat.com> <20190618135821.8644-8-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 28CB06E1B6 for ; Tue, 18 Jun 2019 14:16:08 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id k21so21983454edq.3 for ; Tue, 18 Jun 2019 07:16:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190618135821.8644-8-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: David Airlie , open list , dri-devel@lists.freedesktop.org, "open list:VIRTIO GPU DRIVER" List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdW4gMTgsIDIwMTkgYXQgMDM6NTg6MTVQTSArMDIwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiBVc2UgZ2VtIHJlc2VydmF0aW9uIGhlbHBlcnMgYW5kIGRpcmVjdCByZXNlcnZhdGlv bl9vYmplY3RfKiBjYWxscwo+IGluc3RlYWQgb2YgdHRtLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEdl cmQgSG9mZm1hbm4gPGtyYXhlbEByZWRoYXQuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v dmlydGlvL3ZpcnRncHVfaW9jdGwuYyB8IDM2ICsrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4g IDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZpcnRpby92aXJ0Z3B1X2lvY3RsLmMgYi9kcml2 ZXJzL2dwdS9kcm0vdmlydGlvL3ZpcnRncHVfaW9jdGwuYwo+IGluZGV4IDVjZmZkMmU1NGMwNC4u NmRiNmE2ZTkyZGRlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92aXJ0aW8vdmlydGdw dV9pb2N0bC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZpcnRpby92aXJ0Z3B1X2lvY3RsLmMK PiBAQCAtMTA3LDEyICsxMDcsMTEgQEAgc3RhdGljIGludCB2aXJ0aW9fZ3B1X2V4ZWNidWZmZXJf aW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCXN0cnVjdCB2aXJ0 aW9fZ3B1X2Zwcml2ICp2ZnByaXYgPSBkcm1fZmlsZS0+ZHJpdmVyX3ByaXY7Cj4gIAlzdHJ1Y3Qg ZHJtX2dlbV9vYmplY3QgKmdvYmo7Cj4gIAlzdHJ1Y3QgdmlydGlvX2dwdV9mZW5jZSAqb3V0X2Zl bmNlOwo+IC0Jc3RydWN0IHZpcnRpb19ncHVfb2JqZWN0ICpxb2JqOwo+ICAJaW50IHJldDsKPiAg CXVpbnQzMl90ICpib19oYW5kbGVzID0gTlVMTDsKPiAgCXZvaWQgX191c2VyICp1c2VyX2JvX2hh bmRsZXMgPSBOVUxMOwo+ICAJc3RydWN0IGxpc3RfaGVhZCB2YWxpZGF0ZV9saXN0Owo+IC0Jc3Ry dWN0IHR0bV92YWxpZGF0ZV9idWZmZXIgKmJ1Zmxpc3QgPSBOVUxMOwo+ICsJc3RydWN0IGRybV9n ZW1fb2JqZWN0ICoqYnVmbGlzdCA9IE5VTEw7Cj4gIAlpbnQgaTsKPiAgCXN0cnVjdCB3d19hY3F1 aXJlX2N0eCB0aWNrZXQ7Cj4gIAlzdHJ1Y3Qgc3luY19maWxlICpzeW5jX2ZpbGU7Cj4gQEAgLTE1 NywxMiArMTU2LDExIEBAIHN0YXRpYyBpbnQgdmlydGlvX2dwdV9leGVjYnVmZmVyX2lvY3RsKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAo+ICAJSU5JVF9MSVNUX0hFQUQo JnZhbGlkYXRlX2xpc3QpOwo+ICAJaWYgKGV4YnVmLT5udW1fYm9faGFuZGxlcykgewo+IC0KPiAg CQlib19oYW5kbGVzID0ga3ZtYWxsb2NfYXJyYXkoZXhidWYtPm51bV9ib19oYW5kbGVzLAo+IC0J CQkJCSAgIHNpemVvZih1aW50MzJfdCksIEdGUF9LRVJORUwpOwo+ICsJCQkJCSAgICBzaXplb2Yo dWludDMyX3QpLCBHRlBfS0VSTkVMKTsKPiAgCQlidWZsaXN0ID0ga3ZtYWxsb2NfYXJyYXkoZXhi dWYtPm51bV9ib19oYW5kbGVzLAo+IC0JCQkJCSAgIHNpemVvZihzdHJ1Y3QgdHRtX3ZhbGlkYXRl X2J1ZmZlciksCj4gLQkJCQkJICAgR0ZQX0tFUk5FTCB8IF9fR0ZQX1pFUk8pOwo+ICsJCQkJCSBz aXplb2Yoc3RydWN0IGRybV9nZW1fb2JqZWN0KiksCj4gKwkJCQkJIEdGUF9LRVJORUwgfCBfX0dG UF9aRVJPKTsKPiAgCQlpZiAoIWJvX2hhbmRsZXMgfHwgIWJ1Zmxpc3QpIHsKPiAgCQkJcmV0ID0g LUVOT01FTTsKPiAgCQkJZ290byBvdXRfdW51c2VkX2ZkOwo+IEBAIC0xODEsMTkgKzE3OSwxNSBA QCBzdGF0aWMgaW50IHZpcnRpb19ncHVfZXhlY2J1ZmZlcl9pb2N0bChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAJCQkJcmV0ID0gLUVOT0VOVDsKPiAgCQkJCWdvdG8gb3V0 X3VudXNlZF9mZDsKPiAgCQkJfQo+IC0KPiAtCQkJcW9iaiA9IGdlbV90b192aXJ0aW9fZ3B1X29i aihnb2JqKTsKPiAtCQkJYnVmbGlzdFtpXS5ibyA9ICZxb2JqLT50Ym87Cj4gLQo+IC0JCQlsaXN0 X2FkZCgmYnVmbGlzdFtpXS5oZWFkLCAmdmFsaWRhdGVfbGlzdCk7Cj4gKwkJCWJ1Zmxpc3RbaV0g PSBnb2JqOwoKSSBkaWRuJ3QgYm90aGVyIGxvb2tpbmcsIGJ1dCBJIGd1ZXNzIHRoZXJlJ3Mgc29t ZSByb29tIGZvciBhCmFycmF5LW9mLWdlbS1pZCB0byBnZW1fYm8tcG9pbnRlcnMgaGVscGVyIGZ1 bmN0aW9uPyBXb3VsZCBvbmx5IG1ha2Ugc2Vuc2UKaWYgd2UgY2FuIHNoYXJlIGl0IHdpdGggcGFu ZnJvc3QvdjNkIG1heWJlLgoKPiAgCQl9Cj4gIAkJa3ZmcmVlKGJvX2hhbmRsZXMpOwo+ICAJCWJv X2hhbmRsZXMgPSBOVUxMOwo+ICAJfQo+ICAKPiAtCXJldCA9IHZpcnRpb19ncHVfb2JqZWN0X2xp c3RfdmFsaWRhdGUoJnRpY2tldCwgJnZhbGlkYXRlX2xpc3QpOwo+ICsJcmV0ID0gZHJtX2dlbV9s b2NrX3Jlc2VydmF0aW9ucyhidWZsaXN0LCBleGJ1Zi0+bnVtX2JvX2hhbmRsZXMsICZ0aWNrZXQp Owo+ICAJaWYgKHJldCkKPiAtCQlnb3RvIG91dF9mcmVlOwo+ICsJCWdvdG8gb3V0X3VudXNlZF9m ZDsKPiAgCj4gIAlidWYgPSBtZW1kdXBfdXNlcih1NjRfdG9fdXNlcl9wdHIoZXhidWYtPmNvbW1h bmQpLCBleGJ1Zi0+c2l6ZSk7Cj4gIAlpZiAoSVNfRVJSKGJ1ZikpIHsKPiBAQCAtMjIyLDIxICsy MTYsMjUgQEAgc3RhdGljIGludCB2aXJ0aW9fZ3B1X2V4ZWNidWZmZXJfaW9jdGwoc3RydWN0IGRy bV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCXZpcnRpb19ncHVfY21kX3N1Ym1pdCh2Z2Rl diwgYnVmLCBleGJ1Zi0+c2l6ZSwKPiAgCQkJICAgICAgdmZwcml2LT5jdHhfaWQsIG91dF9mZW5j ZSk7Cj4gIAo+IC0JdHRtX2V1X2ZlbmNlX2J1ZmZlcl9vYmplY3RzKCZ0aWNrZXQsICZ2YWxpZGF0 ZV9saXN0LCAmb3V0X2ZlbmNlLT5mKTsKPiArCWZvciAoaSA9IDA7IGkgPCBleGJ1Zi0+bnVtX2Jv X2hhbmRsZXM7IGkrKykKPiArCQlyZXNlcnZhdGlvbl9vYmplY3RfYWRkX2V4Y2xfZmVuY2UoYnVm bGlzdFtpXS0+cmVzdiwgJm91dF9mZW5jZS0+Zik7CgpIZWxwZXIgdG8gdW5yZWYgYW4gYXJyYXkg b2YgZ2VtIGJvPyBQcm9iYWJseSBhbHNvIG5lZWRlZCBieSBvdGhlciBkcml2ZXJzLgoKCj4gKwlk cm1fZ2VtX3VubG9ja19yZXNlcnZhdGlvbnMoYnVmbGlzdCwgZXhidWYtPm51bV9ib19oYW5kbGVz LCAmdGlja2V0KTsKPiAgCj4gLQkvKiBmZW5jZSB0aGUgY29tbWFuZCBibyAqLwo+IC0JdmlydGlv X2dwdV91bnJlZl9saXN0KCZ2YWxpZGF0ZV9saXN0KTsKPiArCWZvciAoaSA9IDA7IGkgPCBleGJ1 Zi0+bnVtX2JvX2hhbmRsZXM7IGkrKykKPiArCQlpZiAoYnVmbGlzdFtpXSkKPiArCQkJZHJtX2dl bV9vYmplY3RfcHV0X3VubG9ja2VkKGJ1Zmxpc3RbaV0pOwoKSSBhbSBsZWZ0IHdvbmRlcmluZyB3 aG8ncyBob2xkaW5nIHJlZmVyZW5jZXMgb250byB0aGVzZSBidWZmZXJzIG5vdz8gSG93CmRvIHlv dSBtYWtlIHN1cmUgdGhleSBkb24ndCBkaXNhcHBlYXIgdW50aW1lbHk/CgpJIHRoaW5rIGF0bSBp dCdzIHR0bSBtYWtpbmcgc3VyZSBvZiB0aGF0LCBidXQgaWYgeW91IGRyb3AgdGhhdCBjb21wbGV0 ZWx5CnRoZXJlIG5lZWRzIHRvIGJlIHNvbWV0aGluZyBlbHNlLgoKPiAgCWt2ZnJlZShidWZsaXN0 KTsKPiAgCXJldHVybiAwOwo+ICAKPiAgb3V0X21lbWR1cDoKPiAgCWtmcmVlKGJ1Zik7Cj4gIG91 dF91bnJlc3Y6Cj4gLQl0dG1fZXVfYmFja29mZl9yZXNlcnZhdGlvbigmdGlja2V0LCAmdmFsaWRh dGVfbGlzdCk7Cj4gLW91dF9mcmVlOgo+IC0JdmlydGlvX2dwdV91bnJlZl9saXN0KCZ2YWxpZGF0 ZV9saXN0KTsKPiArCWRybV9nZW1fdW5sb2NrX3Jlc2VydmF0aW9ucyhidWZsaXN0LCBleGJ1Zi0+ bnVtX2JvX2hhbmRsZXMsICZ0aWNrZXQpOwo+ICBvdXRfdW51c2VkX2ZkOgo+ICAJa3ZmcmVlKGJv X2hhbmRsZXMpOwo+ICsJZm9yIChpID0gMDsgaSA8IGV4YnVmLT5udW1fYm9faGFuZGxlczsgaSsr KQo+ICsJCWlmIChidWZsaXN0ICYmIGJ1Zmxpc3RbaV0pCj4gKwkJCWRybV9nZW1fb2JqZWN0X3B1 dF91bmxvY2tlZChidWZsaXN0W2ldKTsKPiAgCWt2ZnJlZShidWZsaXN0KTsKPiAgCj4gIAlpZiAo b3V0X2ZlbmNlX2ZkID49IDApCgpQYXRjaCBpdHNlbGYgbG9va3MgY29ycmVjdCwganVzdCBwdXQg ZG93biBteSB0aG91Z2h0cyB3aGlsZSByZXZpZXdpbmcgaXQuCgpSZXZpZXdlZC1ieTogRGFuaWVs IFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0gCj4gMi4xOC4xCj4gCgotLSAK RGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDov L2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVs