From: puranjay12 at gmail.com (Puranjay Mohan) Date: Tue, 18 Jun 2019 22:08:37 +0530 Subject: [Linux-kernel-mentees] [PATCH v2] fs: cramfs_fs.h: Fix shifting signed 32-bit value by 31 bits problem In-Reply-To: <777ee79c-9371-956a-07df-be866796047b@linuxfoundation.org> References: <20190618114947.10563-1-puranjay12@gmail.com> <20190618160847.GC27611@kroah.com> <777ee79c-9371-956a-07df-be866796047b@linuxfoundation.org> Message-ID: <20190618163835.GA4766@arch> List-Id: On Tue, Jun 18, 2019 at 10:15:11AM -0600, Shuah Khan wrote: > On 6/18/19 10:08 AM, Greg KH wrote: > > On Tue, Jun 18, 2019 at 05:19:47PM +0530, Puranjay Mohan wrote: > > > Fix CRAMFS_BLK_FLAG_UNCOMPRESSED to use "U" cast to avoid shifting signed > > > 32-bit value by 31 bits problem. This isn't a problem for kernel builds > > > with gcc. > > > > > > This could be problem since this header is part of public API which > > > could be included for builds using compilers that don't handle this > > > condition safely resulting in undefined behavior. > > > > > > Signed-off-by: Puranjay Mohan > > > > Reviewed-by: Greg Kroah-Hartman > > > > You should resend this and cc: Nicolas Pitre as he is > > the cramfs maintainer. > > > > Puranjay! You can add all the Reviewed-by tags when you resend the patch > with Nicolas Pitre on the thread. > > > Reviewed-by: Shuah Khan > > thanks, > -- Shuah Thanks, I have sent the mail with Nicolas Pitre in CC. --Puranjay